On Tue, Aug 30, 2011 at 1:59 PM, sebb <seb...@gmail.com> wrote:
> On 30 August 2011 19:08, <e_rei...@web.de> wrote:
>> Hi All,
>>
>> i found a Bug in lang3. This tests are failed:
>>
>> Assert.assertTrue(org.apache.commons.lang3.StringUtils.equals(new
>> StringBuffer(""), new StringBuffer("")));
>> Assert.assertTrue(org.apache.commons.lang3.StringUtils.equals(new
>> StringBuffer("123"), new StringBuffer("123")));
>
> The CharSequence interface does not define equals(), so only concrete
> implementations that provide one (such as String) will use anything
> other than Object.equals().
>
> I don't think this is a bug though perhaps the Javadoc could be clearer.
I think a warning in StringUtils.equals that StringBuffer and
StringBuilder don't implement equals as you'd expect and to call
toString before calling such would be valuable.
I think it's weird that the JDK doesn't do a real equals, but I don't
think it's something we should try to fix.
Hen
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscr...@commons.apache.org
For additional commands, e-mail: user-h...@commons.apache.org
