setting log.path should solve the problem too, but this means interpreter and storage-mongo tests won't log the same way the rest of the tests does
On Fri, Feb 6, 2015 at 10:46 AM, Jacques Nadeau <[email protected]> wrote: > I can't see why we do. Also, could consider setting log.path as part of > surefire config to a target subdirectory. > > On Fri, Feb 6, 2015 at 10:15 AM, Abdel Hakim Deneche < > [email protected]> > wrote: > > > I've been looking at this problem as part of DRILL-2028 > > <https://issues.apache.org/jira/browse/DRILL-2028> and the problem > occurs > > in exec/interpreter and contrib/mongo-store modules > > > > the main reason is they have unit tests that use the logging framework > but > > don't include a logback.xml inside their src/test/resources contrary to > > other modules that have unit tests, each has it's own logback.xml that > > doesn't use a FILE appender. > > > > What happens is that when logback looks for a proper configuration file > in > > the classpath it finds multiple occurrences and the one in > > exec/java-exec/src/main/resources is on the top of the list so it gets > > selected, and this particular file has a FILE appender that outputs to > > ${log.path}. > > > > there are multiple solutions that seem to fix the problem to some extent: > > 1. add logback.xml to both modules' test/resources, and make they don't > > contain reference to ${log.path} > > 2. remove exec/java-exec/src/main/resources/logback.xml > > > > My question is: we already have a "main" logback.xml inside the > > distribution module, is there a specific reason we have a copy of it > inside > > exec/java-exec/src/main/resources ? > > > > > > On Mon, Jan 26, 2015 at 9:49 AM, Aditya <[email protected]> wrote: > > > > > Yes, it is exactly that. > > > > > > On Mon, Jan 26, 2015 at 9:01 AM, Jacques Nadeau <[email protected]> > > > wrote: > > > > > > > I've had that when debugging from Eclipse on some occasions. I > haven't > > > yet > > > > tracked down what is creating it but my first guess is it has do with > > the > > > > variable substitution in logback.xml > > > > > > > > On Mon, Jan 26, 2015 at 8:37 AM, Paul Pearcy < > > [email protected] > > > > > > > > wrote: > > > > > > > > > Ah, thanks for confirming. Somehow this file had snuck into my > build: > > > > > exec/interpreter/log.path_IS_UNDEFINED > > > > > > > > > > > > > > > And it threw things off. > > > > > > > > > > Thanks! > > > > > Paul > > > > > > > > > > On 1/26/15, 11:26 AM, "Jinfeng Ni" <[email protected]> wrote: > > > > > > > > > > >Can you please post the contents in /Users/ppearcy/work/beast/ > > > > > >drill/drill-src/exec/interpreter/target/rat.txt? > > > > > > > > > > > >I did a "mvn clean install -DskipTests" build on latest master > > > branch, > > > > > >and > > > > > >it's successful. > > > > > > > > > > > >[INFO] > > > > > > > > > >------------------------------------------------------------------------ > > > > > >[INFO] BUILD SUCCESS > > > > > >[INFO] > > > > > > > > > >------------------------------------------------------------------------ > > > > > >[INFO] Total time: 05:39 min > > > > > >[INFO] Finished at: 2015-01-26T08:19:15-08:00 > > > > > >[INFO] Final Memory: 109M/472M > > > > > >[INFO] > > > > > > > > > >------------------------------------------------------------------------ > > > > > > > > > > > > > > > > > >This is the commit level for the master branch. > > > > > > > > > > > >git log > > > > > >commit 3c6d0ef6595810a0a6b15e48da25fb268ccf2b36 > > > > > > > > > > > > > > > > > >On Mon, Jan 26, 2015 at 8:00 AM, Paul Pearcy < > > > > [email protected]> > > > > > >wrote: > > > > > > > > > > > >> Building latest master, running into this error: > > > > > >> > > > > > >> [ERROR] Failed to execute goal > > > > > >>org.apache.rat:apache-rat-plugin:0.10:check > > > > > >> (rat-checks) on project drill-interpreter: Too many files with > > > > > >>unapproved > > > > > >> license: 1 See RAT report in: > > > > > >> > > > > > > > > > > > > > > > >>/Users/ppearcy/work/beast/drill/drill-src/exec/interpreter/target/rat.txt > > > > > >> -> [Help 1] > > > > > >> > > > > > >> I think things are just broken, but wanted to confirm if others > > have > > > > the > > > > > >> same issue. > > > > > >> > > > > > >> Thanks, > > > > > >> Paul > > > > > >> This email and any attachments may contain confidential and > > > > proprietary > > > > > >> information of Blackboard that is for the sole use of the > intended > > > > > >> recipient. If you are not the intended recipient, disclosure, > > > copying, > > > > > >> re-distribution or other use of any of this information is > > strictly > > > > > >> prohibited. Please immediately notify the sender and delete this > > > > > >> transmission if you received this email in error. > > > > > >> > > > > > > > > > > This email and any attachments may contain confidential and > > proprietary > > > > > information of Blackboard that is for the sole use of the intended > > > > > recipient. If you are not the intended recipient, disclosure, > > copying, > > > > > re-distribution or other use of any of this information is strictly > > > > > prohibited. Please immediately notify the sender and delete this > > > > > transmission if you received this email in error. > > > > > > > > > > > > > > >
