I would assume so, one of the developers more familiar with the planning process might be able to give better insight into the implications of not sending these logical plans through the final physical rewrite rules.
That being said, the code path that it is taking is not doing anything fancy to further optimize/plan the query, it is just making a basic one to one transformation to a physical plan. I wouldn't think it should produce anything invalid, it might just be sub-optimal. The only rewriting of the physical plan that I know of happens in the code here. There are descriptive comments above each of the steps here in the planning code, some of these seem to be removing possible ambiguities introduced in the logical planning phase, you would have to be careful not to create any of these situations in your modified logical plans as they may fail in execution (after they are converted to the physical plan through the alternate path). https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java#L349 On Thu, May 28, 2015 at 4:11 PM, Piotr Sokólski <p...@pyetras.com> wrote: > What about the QueryType.LOGICAL parameter of the submit_plan script? Is > this broken as well? > > -- > Piotr Sokólski > > > On Friday 29 May 2015 at 00:29, Jason Altekruse wrote: > > > Currently Drill does not allow submission of logical plans. I think that > > the web interface is out of date and claims you can submit a logical > plan, > > but this is not correct. We would like to allow for modification of plans > > at the logical level, but we just haven't implemented the feature > currently. > > > > Taking a closer look at the code it looks like we have some old code that > > will do a very basic conversion from a logical plan to a physical one, > but > > it sidesteps the standard and maintained physical planning/optimization > > process entirely. This will be removed ASAP, because there are planning > > changes that take place at the physical planning level that will > introduce > > a risk of inconsistencies if we run plans submitted through this path. > > Hopefully we will be able to add it back soon with proper integration and > > the physical planning steps still applying to the logical plan. > > > > You can try to take a crack at modifying the physical plan, although it > is > > a little more complexity to manage. > > > > On Thu, May 28, 2015 at 9:57 AM, Rajkumar Singh <rsi...@maprtech.com > (mailto:rsi...@maprtech.com)> wrote: > > > > > I am looking to optimize the logical query plan so that I can resubmit > it > > > through the DRILL UI and see the results. > > > > > > Thanks > > > > On May 28, 2015, at 10:23 PM, Sudheesh Katkam <skat...@maprtech.com > (mailto:skat...@maprtech.com)> > > > > > > wrote: > > > > > > > > Hi Rajkumar, > > > > > > > > Here are some links: > > > > http://drill.apache.org/docs/performance-tuning-introduction/ < > > > > > > > > > > http://drill.apache.org/docs/performance-tuning-introduction/> > > > (Performance Tuning Guide) > > > > http://drill.apache.org/docs/query-plans/ < > > > > > > http://drill.apache.org/docs/query-plans/> > > > > > > > > Did you mean optimize physical plan? > > > > > > > > Thanks, > > > > Sudheesh > > > > > > > > > On May 27, 2015, at 11:14 PM, Rajkumar Singh <rsi...@maprtech.com > (mailto:rsi...@maprtech.com)> > > > wrote: > > > > > > > > > > Hi > > > > > > > > > > I am looking for some measures/params to looked upon to optimize > the > > > drill logical query plan if i want to resubmit it through the Drill UI, > > > Could you please points me some docs so that I can go through it. > > > > > > > > > > Rajkumar Singh > > > > > MapR Technologies > > > > > > > > > > > > > > > > > > > > > > > >
