For the sake of simplification (so everybody looking for missing methods in RestClusterClient) I just shared the new methods at [1]. In this way you can add them to the RestClusterClient when you want (if you want to). I also had to change the visibility of some variables and methods in order to make it work. Probably it would be useful to put DTOs of flink-webmonitor in a standalone project in order to be "importable" in the client project..
Best, Flavio [1] https://github.com/fpompermaier/flink-job-server/blob/main/flink-rest-client/src/main/java/org/apache/flink/client/program/rest/RestClusterClientExtended.java On Mon, Nov 23, 2020 at 4:38 PM Flavio Pompermaier <pomperma...@okkam.it> wrote: > I don't know if they need to be added also to the ClusterClient but for > sure they are missing in the RestClusterClient > > On Mon, Nov 23, 2020 at 4:31 PM Aljoscha Krettek <aljos...@apache.org> > wrote: > >> On 23.11.20 16:26, Flavio Pompermaier wrote: >> > Thank you Aljosha,.now that's more clear! >> > I didn't know that jobGraph.getJobID() was the solution for my use >> case..I >> > was convinced that the job ID was assigned by the cluster! >> > And to me it's really weird that the job listener was not called by the >> > submitJob...Probably this should be documented at least. >> > In the meanwhile I extended a little bit the RestClusterClient..do you >> > think it could be worth issuing a PR to add some unimplemented methods? >> > >> > For example I added: >> > - public JobExceptionsInfo getFlinkJobExceptionsInfo(JobID flinkJobId); >> > - public EmptyResponseBody deleteJar(String jarFileName); >> > - public boolean isJobRunning(JobID fjid) >> > - public JarUploadResponseBody uploadJar(Path uploadedFile); >> > >> > and I was also going to add jarRun.. >> >> I would be OK with adding these. But you would also need to add them to >> the base ClusterClient, right? >> >> @Till or @Chesnay, any concerns with this? > >
