Yep!

Simple oversight, it was :/

Cheers,
Matyas

On Thu, Feb 23, 2023 at 10:54 PM Gyula Fóra <gyula.f...@gmail.com> wrote:

> Hey!
> You are right, these fields could have been of the PodTemplate /
> PodTemplateSpec type (probably PodTemplateSpec is actually better).
>
> I think the reason why we used it is two fold:
>  - Simple oversight :)
>  - Flink itself "expects" the podtemplate in this form for the native
> integration as you can see here:
> https://github.com/apache/flink/blob/master/flink-kubernetes/src/test/resources/testing-pod-template.yaml
>
> I think we could actually change Pod -> PodTemplateSpec without breaking
> the api. Let me think about this and see.
>
> Cheers,
> Gyula
>
> On Fri, Feb 24, 2023 at 1:47 AM Mason Chen <mas.chen6...@gmail.com> wrote:
>
>> Hi all,
>>
>> Why does the FlinkDeployment CRD refer to the Pod class instead of the
>> PodTemplate class from the fabric8 library? As far as I can tell, the only
>> difference is that the Pod class exposes the PodStatus, which doesn't seem
>> mutable. Thanks in advance!
>>
>> Best,
>> Mason
>>
>

Reply via email to