I think it should be fine for now. I can compare the following 2 fields to
check if the spec has changed:
- metadata.generation: 4
- status.reconciliationStatus.lastStableSpec: '{"resource_metadata":
{"metadata": {"generation": 2}'
On Sat, Sep 9, 2023 at 2:48 AM Gyula Fóra <gyula.f...@gmail.com> wrote:
> Actually, I just realized, the last fully reconciled spec generation
> should be written into a metadata JSON inside the lastReconciledSpec. So
> this is already available.
>
> For example:
> lastReconciledSpec: '{"spec":{...},"resource_metadata":{"apiVersion":"
> flink.apache.org/v1beta1
> ","metadata":{"generation":2},"firstDeployment":true}}'
>
> It's a bit hidden but it should do the trick :)
> We could discuss moving this to a more standardized status field if you
> think that's worth the effort.
>
> Gyula
>
> On Sat, Sep 9, 2023 at 7:04 AM Gyula Fóra <gyula.f...@gmail.com> wrote:
>
>> Hi!
>> The lastReconciledSpec field serves similar purpose . We also use the
>> generation in parts of the logic but not generically as observed generation
>> .
>>
>> Could you give an example where this would be useful in addition to what
>> we already have?
>>
>> Thanks
>> Gyula
>>
>> On Sat, 9 Sep 2023 at 02:17, Tony Chen <tony.ch...@robinhood.com> wrote:
>>
>>> Hi Flink Community,
>>>
>>> I noticed that there is no status.observedGeneration field in the
>>> FlinkDeployment spec. The closest field to this is
>>> status.reconciliationStatus.lastReconciledSpec. Are there plans to add the
>>> observedGeneration field in the spec? This field will be helpful in
>>> detecting changes in the FlinkDeployment spec.
>>>
>>> Thanks,
>>> Tony
>>>
>>> --
>>>
>>> <http://www.robinhood.com/>
>>>
>>> Tony Chen
>>>
>>> Software Engineer
>>>
>>> Menlo Park, CA
>>>
>>> Don't copy, share, or use this email without permission. If you received
>>> it by accident, please let us know and then delete it right away.
>>>
>>
--
<http://www.robinhood.com/>
Tony Chen
Software Engineer
Menlo Park, CA
Don't copy, share, or use this email without permission. If you received it
by accident, please let us know and then delete it right away.
