On Nov 4, 2008, at 3:25 PM, mvlcek wrote:

<snip>

So, no big problem,  but I would replace the method in
ParentDirSettingsFinderStrategy with this more efficient one, which does not get all files in the directories (and would not cause the above delay):

protected File findBeyondCurrentDir(StartParameter startParameter) { File searchDir = startParameter.getCurrentDir ().getParentFile(); while (searchDir != null && startParameter.isSearchUpwards ()) {
            File settingsFile = new File(searchDir,
startParameter.getSettingsFileName());
            if (settingsFile.exists() && settingsFile.isFile()) {
                return settingsFile;
            }
            searchDir = searchDir.getParentFile();
        }
        return null;
    }

I have committed your patch to trunk. Thanks a lot.

- Hans

--
Hans Dockter
Gradle Project lead
http://www.gradle.org





---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email


Reply via email to