Nope, not as of yet. Based on what you're seeing, it sounds like a CSS
issue, yes, but not an issue with grid layout. The code that you're running
across as the cause was only an intermediate attempt during development and
actually isn't present any longer. The layout was migrated to flexbox prior
to merge.
That said, I would expect something CSS-related to be consistent and
abundantly reproducible. So far, I can't reproduce it at all in the only
copy of Safari I (currently) have access to.
On Wed, Aug 11, 2021 at 2:31 PM Leo Nikolaev <nikol...@kasatkina.org> wrote:
> Mike, any update on this? Looks like a CSS bug in tile grid :)
>
> Cheers,
> Leo
>
> > On 6 Aug 2021, at 10:42, Leo Nikolaev <nikol...@kasatkina.org> wrote:
> >
> > Okay, I’ve done some investigations :)
> >
> > First of all, as soon as we see cache-dependency, the problem should not
> be with .js-code, it’s recompiled, but as far as I can see Angular uses
> caching.
> >
> > The problem looks like a result of a change in file
> guacTiledClients.html. There was a line:
> > ng-style="{ 'width' : getTileWidth(), 'height' : getTileHeight() }”
> >
> > And it was working perfectly, but in a new version we have:
> > ng-attr-style="{{ getTileGridCSS(clientGroup, $index) }}”
> >
> > So, when viewing Elements in Safari, I can see the following structure:
> >
> > <guac-tiled-clients ...>
> > <ul ...>
> > <!-- ngRepeat: client in clientGroup.clients —>
> > <li class="client-tile ng-scope focused" ...>
> > </li>
> > <!-- end ngRepeat: client in clientGroup.clients —>
> > </ul>
> > </guac-tiled-clients>
> >
> > And magically inner li element has non-zero width, but zero height. If I
> change it manually, the picture appears, and all is working good.
> >
> > Digging deeper shows me the source of zero height - it is mentioned in
> client.css, with two classes:
> > .client-view
> > .client-view-content
> >
> > Both of them declare “100%” height, but looks like it does not work in
> Safari. Any ideas?
> >
> > Cheers,
> > Leo
> >
> >> On 5 Aug 2021, at 23:49, Mike Jumper <mike.jum...@glyptodon.com> wrote:
> >>
> >> Well, so far no luck reproducing what you're seeing, but perhaps my
> test setup is too up-to-date:
> >>
> >> macOS 11.5
> >> Safari 14.1.2
> >>
> >> I'll try again and, failing that, see if there's some way to duplicate
> your exact setup down to the version.
> >>
> >> Michael Jumper
> >> CEO, Lead Developer
> >> Glyptodon Inc.
> >>
> >>
> >> On Wed, Aug 4, 2021 at 1:49 PM Mike Jumper <mike.jum...@glyptodon.com>
> wrote:
> >> Ah, OK.
> >>
> >> On Wed, Aug 4, 2021, 13:48 Leo Nikolaev <nikol...@kasatkina.org> wrote:
> >> I do need cherry-pick to fix regression from 641, you’ve told me that;
> I’ve found it fixed on 037ed212 and put it on. Without it Guacamole fails
> to even show me a login form, complaining about MySQL syntax errors.
> >>
> >> Cheers,
> >> Leo
> >>
> >>> On 4 Aug 2021, at 23:45, Mike Jumper <mike.jum...@glyptodon.com>
> wrote:
> >>>
> >>> On Wed, Aug 4, 2021, 13:33 Leo Nikolaev <nikol...@kasatkina.org>
> wrote:
> >>> Okay, I found it.
> >>>
> >>> Safari bug is in the GUACAMOLE-724 series of commits.
> >>> Broken commit: c2b2522 - GUACAMOLE-724: Correct rendering of tiled
> clients on IE10+ by migrating to grid layout.
> >>>
> >>> Unfortunately, I believe the code from that commit has already been
> replaced with a different approach.
> >>>
> >>> Last working commit: 09288b7
> >>>
> >>> This may be helpful.
> >>>
> >>>
> >>> Steps to reproduce:
> >>>
> >>> 1. Checkout commit:
> >>>
> >>> git checkout c2b2522
> >>>
> >>> 2. Cherry-pick fix from GUACAMOLE-641:
> >>>
> >>> git cherry-pick -m 1 037ed212
> >>>
> >>> What does cherry-picking this commit have to do with the issue at
> hand? Are you unable to reproduce the issue unless you cherry pick this?
> >>>
> >>> ...
> >>> Should I make a video?
> >>>
> >>> No, I don't think that would help. We need to be able reproduce what
> you're seeing ourselves.
> >>>
> >>> The steps to reproduce (connect to something) are straightforward; it
> just so far is working absolutely fine when I test against Safari myself.
> >>>
> >>> - Mike
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: user-unsubscr...@guacamole.apache.org
> >> For additional commands, e-mail: user-h...@guacamole.apache.org
> >>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: user-unsubscr...@guacamole.apache.org
> > For additional commands, e-mail: user-h...@guacamole.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscr...@guacamole.apache.org
> For additional commands, e-mail: user-h...@guacamole.apache.org
>
>
