On 24/11/2010 09:35, Dan Godfrey wrote:
> Cool, although you might've jumped the gun a little, I was nowhere
> near finished ;)
> I was more just after some feedback about whether to continue in a
> JBehave branch, or just to put it into a separate JAR.
>
> I've had a quick look, and out of the box
> AnnotatedPathRunnerUsingGuice isn't actually running the stories, it
> is however listing them in the junit results view.
It's now fixed - turns out I was overly optimistic about having a single
runner, you need DI specific ones, as is the case for the other runner.
And some further comments on the points below:
> I was planning on:
> * Trying to expand it out a bit so that the individual scenarios are
> displayed as passing/failing in the JUnit Results View.
yes - nice to have
> * Make it so stories with pendings fail properly (I think they show as
> having passed)
This is controlled by the PendingStepStrategy - which has two impls
Passing and Failing. The default is "Passing" but you can configure it
to fail.
> * Remove the ability to change the batch/ignoreFailures/etc config as
> all this does is potentially break the runner if you have the wrong
> values.
Why would you want to do that? Let's discuss the use case you're
referring to first. I can't see the "potential breaking of the runner"
> * Put sensible error messages in the stacktrace view, it doesn't
> actually give the reason for failure at the moment.
Again, it's there but configurable (reportFailureTrace boolean flag in
the PrintStreamOutput).
Cheers
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
