This was my first directed trawl through the codebase. Really
expressive tests - 'the code I would like to have written'!
The method names generated for pending steps are better than I
suggested, since they include 'given', 'when' etc and are therefore much
easier to read e.g. in an IDE's outline view on a step class.
Everything else looks great, as confirmed by the Trader pending story.
===
Just one other thing - not sure where to say it, but here seems as good
a place as any. It's about the bubbling up of pendingness into
scenarios, stories, and test runs as a whole. It would be useful if
(i) stories with no steps were reported as pending, and their
constituent scenarios too
(ii) stories with any pending steps were reported as pending, and their
constituent scenarios too
(iii) a test run with any pending stories was itself reported as
pending, even if it was also regarded as successful
When I say 'reported as', I mean in the kind of end result you can see
at target/jbehave/view/reports.html. In jbehave-trader-example, I tried
adding a new story alongside the existing test stories, and of course it
was reported, but as successful only - nothing to indicate there's no
implementation as suggested in (i) above.
This kind of behaviour would serve as a flag to keep the implementer
honest and maintain the flow of top-down development: you've not
implemented x if you've not implemented something x depends on. It
would help keep story development and implementation in synch: if I make
a modification to a story (or create a whole new story) and JBehave can
tell me everywhere that implementation is pending, that's great.
Jon
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
