This is generally how it works but in the case of this patch: - A release was planned the last week-end and is in progress (Vote is open) so it was better not to commit and it is still the case for at least 48 Hours - Undo features may introduce big changes in JMeter User experience (look at what's in BugZilla patch) so until it's stable in my opinion it should not be commited unless it can be disabled - And yes in it's state there was a big issue when loading important Test Plan but many Thanks to Andrey as proposed patch is really a good basis.
Finally as there need to be some compromise (for now) (for example number of undo retained, or the fact that merge is not undoable), it had some meaning to have users wishes so to answer this on users list. But I will switch this discussion to dev list. Regards Philippe On Mon, Jan 30, 2012 at 2:17 PM, Felix Frank <f...@mpexnet.de> wrote: > Hi, > > this would probably be better suited to a dev list, but I don't > subscribe to that, so here goes :-) > > IMO, instead of rewriting submitted patches gravely, it would be > preferable to merge them as-is (so long as they don't introduce severe > problems) and submit a new patch that makes all the fixes that the > reviewer deems to be in order. > That way, SVN history preserves the distinction between what Andrey > implemented and what you added. > > Of course, it's up to each OSS project to decide how to treat code > submissions, so this is just a pair of cents I throw into the round. > > Cheers, > Felix > > On 01/30/2012 01:50 PM, Philippe Mouawad wrote: > > Hello Félix, > > CAN you explain what you mean by followup patch ? > > > > Thanks > > Regards > > Philippe > > --------------------------------------------------------------------- > To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org > For additional commands, e-mail: user-h...@jmeter.apache.org > > -- Cordialement. Philippe Mouawad.
