Philippe,

Did you commit your last change about what to do when no expires and no 
mnax-age are in teh headers?
I don't see the change in svn

Thx

Le 2012-07-14 11:53, Philippe Mouawad a écrit :
Hello,
I modified the fix to comply with:
RFC 2616 <http://tools.ietf.org/html/rfc2616> section 13.2.4.
When no expires and no max-age:

Also, if the response does have a Last-Modified time, the heuristic
    expiration value SHOULD be no more than some fraction of the interval
    since that time. A typical setting of this fraction might be 10%.


But if you don't send Last-Modified time , I don't see what the spec says
about it.

Regards
Philippe
On Sat, Jul 14, 2012 at 5:06 PM, sebb <seb...@gmail.com> wrote:

On 14 July 2012 14:21, titou10 <titou10.tito...@gmail.com> wrote:
(Sorry for the delay, I was out of office)

Thanks Philippe for the fix but it is still not complete IMHO.

Our application send backs pages with "Cache-control=private" WITHOUT any
"max-age" header
Does the page have an Expires header?

And the browser caches the page (until the end of the session I guess..).
Proved by firebug

In your fix, max-age should not be mandatory and if absent, IMHO, the
page
should be kept in page "forever" (ie until the session ends)

In my own fix for this bug, when max-age is missing, I consider it to be
egal to one week (maxAgeInSecs=604800), which is, for us, mean
"forever"...because I didn't want to change the whole "CacheManager"
component logic for this.

WDYT?

Thanks

Le 2012-07-08 05:45, Philippe Mouawad a écrit :

Hello,
Reading specification:
private Indicates that all or part of the response message is intended
for
a single user and MUST NOT be cached by a shared cache. This allows an
origin server to state that the specified parts of the
response are intended for only one user and are not a valid response for
requests by other users. A private (non-shared) cache MAY cache the
response.

*Note:* This usage of the word private only controls where the response
may
be cached, and cannot ensure the privacy of the message content.


So I agree with you "titou10 titou 10" that JMeter should cache entry. I
checked code and in fact it is not doing so.
Bug is now fixed:

     - https://issues.apache.org/bugzilla/show_bug.cgi?id=53521

Feel free to download nightly build when it's available and check if
issue
is fixed for you

Regards

Philippe M.

http://www.ubik-ingenierie.com


On Sun, Jul 8, 2012 at 1:34 AM, Shmuel Krakower <shmul...@gmail.com>
wrote:

Hi
I think that by default all browsers are caching everything unless this
header is set to private (or if other headers are set to not allow
caching).

For me JMeter cache manager caches all resources, even those without
cache-control directive.

So I am unsure why you had to make a patch.

Regards,
Shmuel.
בתאריך 2012 7 3 15:54, מאת "titou10 titou10" <
titou10.tito...@gmail.com>:
The Cache Manager component in JMeter v2.7 caches only content that
have an header with "Cache-control=public" and a "max-age" directive

Usually, browsers also cache content that have "Cache-control=private"
without max-age.. (At least firefox 13 in win7 do that)

I have patched JMeter to do so, with an option in the GUI to activate
or disable caching of such content.

Are the reason why this is not the standard behaviour?
Is someone else interested in this patch?

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org
For additional commands, e-mail: user-h...@jmeter.apache.org





---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org
For additional commands, e-mail: user-h...@jmeter.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org
For additional commands, e-mail: user-h...@jmeter.apache.org





---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscr...@jmeter.apache.org
For additional commands, e-mail: user-h...@jmeter.apache.org

Reply via email to