Thanks Felix,
It's my mistake, the origin of the error is not related to jmeter.

Best regards


On Fri, Apr 7, 2023 at 9:13 AM Felix Schumacher <
[email protected]> wrote:

> Having had a look at the current code, we already add the separator char
> to the specialChars and my simple test quotes the comma variable. (minimal
> example test attached)
>
> Did I miss something?
>
> Felix
> Am 07.04.23 um 11:05 schrieb Felix Schumacher:
>
> Could not you change the separator char to one that is not contained in your 
> data?
>
> Otherwise, you could open an issue or even a PR to add the separator char to 
> the specialChars.
>
> Felix
>
> Am 7. April 2023 10:56:30 MESZ schrieb OUFDOU Anas <[email protected]> 
> <[email protected]>:
>
> Hello,
>
> With URL having "," like 
> (https://xxxxx/looks?market=FR&language=fr,587,0,0,1680852961099) it's
> logged in CSV without quotes.
>
>
> 1680852979075,587,GetLLPLookFR,200,OK,AFH-APC 
> 2-1,text,true,,13783,1285,3,4,https://xxxxx/looks?market=FR&language=fr,587,0,0,1680852961099
>
> The problem in Jmeter code is in this class 
> (https://github.com/apache/jmeter/blob/rel/v5.4.3/src/core/src/main/java/org/apache/jmeter/save/CSVSaveService.java)
> in the method
>
>    public static String quoteDelimiters(String input, char[] specialChars)
> {
>        if (StringUtils.containsNone(input, specialChars)) {
>            return input;
>        }
>        StringBuilder buffer = new StringBuilder(input.length() + 10);
>        final char quote = specialChars[1];
>        buffer.append(quote);
>        for (int i = 0; i < input.length(); i++) {
>            char c = input.charAt(i);
>            if (c == quote) {
>                buffer.append(quote); // double the quote char
>            }
>            buffer.append(c);
>        }
>        buffer.append(quote);
>        return buffer.toString();
>    }
> adding quote only when quote is present and not the delimiter.
>
>
> There is any solution to force quote on all urls ??
> Many thanks
> --
> Cordialement,
> -------------
> Anas OUFDOU
>
>

-- 
Cordialement,
-------------
Anas OUFDOU

Reply via email to