Hi Dave,

just've committed the fix, would you mind trying latest trunk
(2.10.2-svn-3)? that should solve the issue


thanks + br,
juan pablo


On Sun, Jun 22, 2014 at 8:36 PM, Juan Pablo Santos Rodríguez <
juanpablo.san...@gmail.com> wrote:

> Hi Dave,
>
> indeed, it's a bug, most probably introduced in 2.10.1-svn-4. We were
> using two libraries for markup generation, ECS and JDOM2, and as the first
> had stopped its development on 2010, we switched to the second one.
>
> The problem is that JDOM2, unless told otherwise, treats empty elements as
> <empty/> instead of <empty></empty>, so you're getting <table
> class="recentchanges" cellpadding="4" /> for an empty recent changes table
> instead of <table class="recentchanges" cellpadding="4" ></table>. This
> behaviour can be seen if you save a WikiPage with the following content:
> [{RecentChangesPlugin since=-1}]
>
> I'm filing a JIRA for this based on your email and a test + fix afterwards
>
>
> br,
> juan pablo
>
>
> On Fri, Jun 20, 2014 at 7:05 PM, Dirk Frederickx <
> dirk.frederi...@gmail.com> wrote:
>
>> Dave,
>>
>> Probably the DOM tree is left unbalanced  (eg not all <div> have a </div>
>> ),  by the recent-changes plugin.
>>
>> When the DOM tree is not balanced,  parts of the following tab can appear
>> on the next tab.
>>
>> Can you check in your browser the DOM-tree:  the developer console allows
>> you to do that.
>>
>>
>> dirk
>>
>>
>> dirk
>>
>>
>>
>> On Fri, Jun 20, 2014 at 8:45 AM, Dave Koelmeyer <
>> dave.koelme...@davekoelmeyer.co.nz> wrote:
>>
>> > Hi Folks,
>> >
>> > I'm observing the following using the 2.10.1 release. It certainly did
>> not
>> > happen with 2.9.x releases and earlier.
>> >
>> > On my wiki front page I have a recent changes plugin inserted. When
>> > sufficient time has elapsed such that there are no recent changes to
>> > display, the following happens:
>> >
>> > https://davekoelmeyer.files.wordpress.com/2014/06/jspwiki-2.png
>> >
>> > Note two things. First, there is a persistent file upload dialogue
>> > visible, which I haven't triggered. Second, the last modified note for
>> the
>> > page has been shoved up at top-left.
>> >
>> > By comparison, this is what is visible when recent changes are
>> available.
>> > I can also resolve the above behaviour by editing any page such that
>> there
>> > is a recent change to then display:
>> >
>> > https://davekoelmeyer.files.wordpress.com/2014/06/jspwiki-1.png
>> >
>> > In other words, the page appears normally.
>> >
>> > This is a stock-standard install, with no modification of themes or
>> > templates having taken place. I am pointing JSPWiki at the same set of
>> data
>> > as used for earlier releases. Clearing out the working directory does
>> not
>> > change the behaviour. It appears to manifest itself at least with the
>> > PlainVanilla and CleanBlue skins.
>> >
>> > Any idea what has happened here, and has anyone else seen the same
>> thing?
>> >
>> > Cheers,
>> > Dave
>> >
>> >
>> >
>> >
>> >
>>
>
>

Reply via email to