Hi Juan, (to check whether I understood it correctly:)
This new JSP customer tag would be used inside the common header.jsp ; to generate all the different <link rel=....> html tags. <wiki:favicons /> A new property would be created to contain the path to a folder with the favicon files: default = "/favicons". During initialisation JSPWiki would validate the favicons folder (all files exists?) and generate the correct HTML. The latter is cached and retrieved with <wiki:favicons /> It seems that the correct html is to be build up based on some values inside browserconfig.xml and site.webmanifest. But that should be feasible I guess. dirk On Fri, Apr 20, 2018 at 6:37 PM, Juan Pablo Santos Rodríguez < juanpablo.san...@gmail.com> wrote: > Hi Dirk! > > just going through your last commit to see how to provide an easy change of > favicon > > Rather than a plugin, I was thinking more of a JSP custom tag, which should > check against a property on (custom-)jspwiki.properties. > > If absent, it should display the current favicon, if present, print that > property value as is. That property would contain the appropiate HTML code, > but as the favicon should probably have to be included on the war anyway > (i.e. task for the admin), I was wondering if it was enough just to > point to > https://jspwiki-wiki.apache.org/Wiki.jsp?page=How%20to% > 20change%20the%20site%20logo#section-How+to+change+the+ > site+logo-OneMoreThingFavicons > . > > thoughts? > > > thx! > juan pablo > > > > On Mon, Apr 16, 2018 at 9:22 PM, Dirk Frederickx < > dirk.frederi...@gmail.com> > wrote: > > > Hi Juan > > > > Favicons are set in the commonheader.jsp. > > Unfortunately they cannot be modified via css. > > > > The only way to change them, is via access to the root-directory. So a > > task for the admin. > > If we want to easy change it, we need to build it in as a feature. (eg > > new plugin?) > > > > br, > > dirk > > > > > > On Sun, Apr 15, 2018 at 11:57 PM, Juan Pablo Santos Rodríguez < > > juanpablo.san...@gmail.com> wrote: > > > > > Hi Dirk, > > > > > > didn't knew about themes, looks impressive! > > > > > > wrt, changing the logo, is it also possible to set up a custom favicon? > > > both things were requested at JSPWIKI-363 (adding a pointer to the > latter > > > article on there right now) > > > > > > > > > thx + br, > > > juan pablo > > > > > > On Sun, Apr 15, 2018 at 9:22 PM, Dirk Frederickx < > > > dirk.frederi...@gmail.com> > > > wrote: > > > > > > > Hi Dietrich, > > > > > > > > Txs for the valuable feedback ! Much appreciated. > > > > > > > > (1) should the Haddock template replace the existing default template > > in > > > > the long term? > > > > >> Probably it will. > > > > >> For now we keep both, but only the Haddock template is actively > > being > > > > developed. > > > > > > > > (2) are there efforts, to port the so-called "skins" of the default > > > > template (for example CleanBlue) also for > > > > Haddock Template? > > > > >> I removed the concept of skins from the Haddock template, > > introducing > > > > the notion of "themes". > > > > >> You can use the %%add-css style to modify any style of the > > template; > > > > from within a wiki-page. > > > > >> I've quickly build an example page > > > > https://jspwiki-wiki.apache.org/Wiki.jsp?page=Clean%20Blue%20Theme > to > > > show > > > > what could be possible. > > > > > > > > (3) Usability: > > > > (3a) why does the history only appear when the mouse is moved into an > > > area? > > > > (3b) Why is there no input field for the search? Instead, the mouse > > must > > > > be moved to a symbol, then you have to wait, then the mouse on > > > > Input field are moved and clicked with the left mouse button. > > > > That's what I call awkward! > > > > >> History/Breadcrumbs are only shown on hover, to avoid clutter of > the > > > > header section. > > > > >> Initially I wanted to remove the breadcrumbs from the template, > as > > a > > > > user mostly use the browser history. > > > > >> Any suggestions of a better way to show them? > > > > > > > > >> Search input field / aka Quick Navigation : > > > > >> I agree that the current UI could be improved, as it may not be > > > obvious > > > > for a new site visitor. > > > > >> Better would be to have only one SEARCH UI (Quick Navigation + > > Search > > > > Page) instead of two. > > > > >> And the search functionality should be reached after a mouse > click, > > > > instead of a hover effect. (more common pattern used on the internet) > > > > >> This also would work better on mobile devices. > > > > > > > > > > > > (4) Internationalization: the name of the page is displayed at the > top > > of > > > > the page, > > > > especially on the pages LoginHelp, EditPageHelp, SearchPageHelp, > > > TitleBox, > > > > MoreMenu, > > > > HomeMenu, CopyrightNotice, SessionExpired. These page names must be > > > > translatable. > > > > See the attachment how arkward it looks when using german. > > > > >> JSPWiki does not support (yet) localisation of pages. > > > > > > > > >> As a work-around, you could put an ALIAS on the standard pages > > > > >> This would automatically redirect to the german version of the > > > standard > > > > pages. > > > > [{SET alias="<german name of page>"}] > > > > > > > > >> As a future improvement, we could consider to extend the IfPlugin > > with > > > > some basic support for localization > > > > [{If language="de" alias="XXXX" }] > > > > The language would then be compared with the language chosen in > > the > > > > UserPreferences. > > > > > > > > (5) Adaptability: The top left pictogram must be replaceable with a > > > company > > > > logo. > > > > Where can I find the documentation, how it works? > > > > >> I've added a documentation how to do this: > > > > https://jspwiki-wiki.apache.org/Wiki.jsp?page=How%20to% > > > > 20change%20the%20site%20logo > > > > > > > > > > > > BR, > > > > dirk > > > > > > > > > > > > On Fri, Apr 13, 2018 at 1:04 PM, Schmidt Dietrich < > > > > dietrich.schm...@gevas.de > > > > > wrote: > > > > > > > > > Hello, > > > > > > > > > > I evaluate the Haddock template for productive use > > > > > and have some questions / comments. > > > > > > > > > > (1) should the Haddock template replace the existing default > template > > > in > > > > > the long term? > > > > > > > > > > (2) are there efforts, to port the so-called "skins" of the default > > > > > template (for example CleanBlue) also for > > > > > Haddock Template? > > > > > > > > > > (3) Usability: > > > > > (3a) why does the history only appear when the mouse is moved into > an > > > > area? > > > > > (3b) Why is there no input field for the search? Instead, the mouse > > > must > > > > > be moved to a symbol, then you have to wait, then the mouse on > > > > > Input field are moved and clicked with the left mouse button. > > > > > That's what I call awkward! > > > > > > > > > > (4) Internationalization: the name of the page is displayed at the > > top > > > of > > > > > the page, > > > > > especially on the pages LoginHelp, EditPageHelp, SearchPageHelp, > > > > TitleBox, > > > > > MoreMenu, > > > > > HomeMenu, CopyrightNotice, SessionExpired. These page names must be > > > > > translatable. > > > > > See the attachment how arkward it looks when using german. > > > > > > > > > > (5) Adaptability: The top left pictogram must be replaceable with a > > > > > company logo. > > > > > Where can I find the documentation, how it works? > > > > > > > > > > best regards > > > > > Dietrich Schmidt > > > > > > > > > > P.S. this ist the google translation oft the german original found > > > > further > > > > > down. > > > > > > > > > > Hallo, > > > > > > > > > > ich evaluiere das Haddock Template für den produktieven Einsatz > > > > > und habe einige Fragen/Anmerkungen. > > > > > > > > > > (1) soll das Haddock Template langfristig das bisherige default > > > Template > > > > > ersetzen? > > > > > > > > > > (2) gibt es Bemühungen, die sog. "Skins" des default Template (z.B. > > > > > CleanBlue) auch zum > > > > > Haddock Template hinzuzufügen? > > > > > > > > > > (3) Benutzerfreundlichkeit: > > > > > (3a) warum wird der Verlauf nur angezeigt, wenn die Maus in einen > > > Bereich > > > > > bewegt wird? > > > > > (3b) Warum gibt es kein Eingabefeld für die Suche? Statt dessen muß > > die > > > > > Maus > > > > > auf ein Symbol bewegt werden, dann muß gewartet werden, dann die > Maus > > > auf > > > > > ein > > > > > Eingabefeld bewegt werden und mit der linken Maustaste geklickt > > werden. > > > > > Das nenne ich umständlich! > > > > > > > > > > (4) Internationalisierung: Der Name der Seite wird am oberen > > Seitenrand > > > > > angezeigt, > > > > > insbesondere auch bei den Seiten LoginHelp, EditPageHelp, > > > SearchPageHelp, > > > > > TitleBox, MoreMenu, > > > > > HomeMenu, CopyrightNotice, SessionExpired. Diese Seitennamen müssen > > > > > übersetztbar sein. > > > > > Siehe den Anhang, wie schrecklich das aussieht in Deutsch. > > > > > > > > > > (5) Anpassbarkeit: Das Piktogramm links oben muß durch ein > > Firmen-Logo > > > > > ersetztbar sein. > > > > > Wo finde ich die Dokumentation, wie das funktioniert? > > > > > > > > > > mit freundlichen Grüßen > > > > > Dietrich Schmidt > > > > > > > > > > -- > > > > > > > > > > Dietrich Schmidt > > > > > GEVAS software GmbH > > > > > > > > > > > > > > >
