Awesome. From what you are mentioning I think our changes might complement each other well, such as the work I did to get cellar int tests to be smarter about testing cellar, using the distributed executors.. I'm hoping the way I changed handling the properties will be well received.. I simplified them and am using ManagedServiceFactories. I'm sure your second pair of eyes will catch the rough areas that are in there. Let me know if I can help in any additional way.
Ryan On Feb 21, 2014 2:10 AM, "Jean-Baptiste Onofré" <j...@nanthrax.net> wrote: > Hi Ryan, > > thanks for the update. > > As I did some update (Hazelcast 3.1.0 update, change in the cluster event, > usage of JMX whiteboard, etc) on Cellar 3.0.0, I will merge your change > with mine. > > Thanks, > Regards > JB > > On 02/21/2014 05:12 AM, Ryan Moquin wrote: > >> So after probably a year of learning how the Cellar trunk >> (3.0.0-SNAPSHOT) works, and after my third strategy for overhauling the >> codebase in a way that I thought would improve it, I finally achieved >> what I didn't think I'd ever achieve: >> >> Results : >> >> Tests run: 11, Failures: 0, Errors: 0, Skipped: 0 >> >> [INFO] >> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ >> org.apache.karaf.cellar.itests --- >> [INFO] Building jar: >> C:\dev\clones\karaf-cellar\itests\target\org.apache. >> karaf.cellar.itests-3.0.0-SNAPSHOT.jar >> [INFO] >> [INFO] --- maven-site-plugin:3.2:attach-descriptor (attach-descriptor) @ >> org.apache.karaf.cellar.itests --- >> [INFO] >> [INFO] --- maven-install-plugin:2.5.1:install (default-install) @ >> org.apache.karaf.cellar.itests --- >> [INFO] Installing >> C:\dev\clones\karaf-cellar\itests\target\org.apache. >> karaf.cellar.itests-3.0.0-SNAPSHOT.jar >> to C:\Users\Ryan\.m2\repository\org\apach >> e\karaf\cellar\org.apache.karaf.cellar.itests\3.0.0- >> SNAPSHOT\org.apache.karaf.cellar.itests-3.0.0-SNAPSHOT.jar >> [INFO] Installing C:\dev\clones\karaf-cellar\itests\pom.xml to >> C:\Users\Ryan\.m2\repository\org\apache\karaf\cellar\org. >> apache.karaf.cellar.itests\3.0 >> .0-SNAPSHOT\org.apache.karaf.cellar.itests-3.0.0-SNAPSHOT.pom >> [INFO] >> ------------------------------------------------------------------------ >> [INFO] Reactor Summary: >> [INFO] >> [INFO] Apache Karaf :: Cellar ............................ SUCCESS >> [2.460s] >> [INFO] Apache Karaf :: Cellar :: Core .................... SUCCESS >> [5.723s] >> [INFO] Apache Karaf :: Cellar :: Hazelcast ............... SUCCESS >> [2.043s] >> [INFO] Apache Karaf :: Cellar :: Config .................. SUCCESS >> [1.661s] >> [INFO] Apache Karaf :: Cellar :: Features ................ SUCCESS >> [1.459s] >> [INFO] Apache Karaf :: Cellar :: Bundle .................. SUCCESS >> [1.305s] >> [INFO] Apache Karaf :: Cellar :: OBR ..................... SUCCESS >> [1.031s] >> [INFO] Apache Karaf :: Cellar :: DOSGi ................... SUCCESS >> [1.361s] >> [INFO] Apache Karaf :: Cellar :: Event Support ........... SUCCESS >> [0.681s] >> [INFO] Apache Karaf :: Cellar :: Utils ................... SUCCESS >> [0.797s] >> [INFO] Apache Karaf :: Cellar :: Shell ................... SUCCESS >> [1.261s] >> [INFO] Apache Karaf :: Cellar :: Cloud ................... SUCCESS >> [1.608s] >> [INFO] Apache Karaf :: Cellar :: Management .............. SUCCESS >> [1.266s] >> [INFO] Apache Karaf :: Cellar :: Webconsole .............. SUCCESS >> [0.758s] >> [INFO] Apache Karaf :: Cellar :: Assembly ................ SUCCESS >> [21.340s] >> [INFO] Apache Karaf :: Cellar :: Samples ................. SUCCESS >> [0.067s] >> [INFO] Apache Karaf :: Cellar :: Samples :: DOSGi ........ SUCCESS >> [0.168s] >> [INFO] Apache Karaf :: Cellar :: Samples :: DOSGi Greeter :: API >> SUCCESS [0.398s] >> [INFO] Apache Karaf :: Cellar :: Samples :: DOSGi Greeter :: Service >> SUCCESS [0.616s] >> [INFO] Apache Karaf :: Cellar :: Samples :: DOSGi Greeter :: Client >> SUCCESS [0.715s] >> [INFO] Apache Karaf :: Cellar :: Samples :: Hazelcast Application >> SUCCESS [0.764s] >> [INFO] Apache Karaf :: Cellar :: Samples :: Camel Hazelcast Application >> SUCCESS [0.095s] >> [INFO] Apache Karaf :: Cellar :: Samples :: Camel Hazelcast Application >> :: Producer SUCCESS [0.645s] >> [INFO] Apache Karaf :: Cellar :: Samples :: Camel Hazelcast Application >> :: Consumer SUCCESS [0.469s] >> [INFO] Apache Karaf :: Cellar :: Integration Tests ....... SUCCESS >> [8:13.492s] >> [INFO] >> ------------------------------------------------------------------------ >> [INFO] BUILD SUCCESS >> [INFO] >> ------------------------------------------------------------------------ >> [INFO] Total time: 9:04.047s >> [INFO] Finished at: Thu Feb 20 22:48:27 EST 2014 >> [INFO] Final Memory: 58M/543M >> [INFO] >> ------------------------------------------------------------------------ >> >> So obviously, I was able to make the improvements to the entire codebase >> (I think it should be simpler and more efficient) I was able to get the >> final test to pass tonight. >> >> If anyone would like to try it out with Karaf 3.0.0, you can access the >> code in my github rmoquin\karaf-cellar fork. >> >> Hopefully this work will be beneficial! >> >> Ryan >> > > -- > Jean-Baptiste Onofré > jbono...@apache.org > http://blog.nanthrax.net > Talend - http://www.talend.com >
