Hi folks, IMO, the copyright date mismatch is not a blocker.
I'm giving a +1 for RC1. I performed the following validation steps: 1. Verified the signature: smolnar-MBP15:knox-1.5-RC1 smolnar$ gpg --verify knox-1.5.0.zip.asc gpg: assuming signed data in 'knox-1.5.0.zip' gpg: Signature made Sun Nov 22 20:46:05 2020 CET gpg: using RSA key CB951DC938391FE207682BB582F9C371587C089B gpg: Good signature from "Larry McCay (CODE SIGNING KEY) <lmc...@apache.org>" [unknown] 2. Successfully built the source from branch v1.5.0 3. Deployed RC1 in a test cluster together with CM and confirmed: - Knox started successfully - Accessed the Knox Home page w/o any issue - Accessed the Knox Admin UI w/o any issue - CM service discovery worked as expected - Proxying through the Knox Gateway worked as expected - Logout button appeared and worked as expected - gateway/gateway-audit logs generated properly and I found related log entries of newly added features Cheers, Sandor On Fri, Nov 27, 2020 at 9:21 PM larry mccay <larry.mc...@gmail.com> wrote: > Yes, it should. Not sure whether this is a blocker or not. Thoughts? > > On Wed, Nov 25, 2020, 9:59 PM Phil Zampino <pzamp...@apache.org> wrote: > >> Checking the NOTICE file in the RC, it has the copyright date as >> 2012-20*19*. >> Should it rather be 2012-20*20*? >> >> >> >> On Sun, Nov 22, 2020 at 2:59 PM larry mccay <lmc...@apache.org> wrote: >> >> > All - >> > >> > Release candidate #1 for the Apache Knox 1.5.0 release is available at: >> > >> > https://dist.apache.org/repos/dist/dev/knox/knox-1.5.0/ >> > >> > The release candidate is a zip archive of the sources in: >> > >> > https://https://gitbox.apache.org/repos/asf/knox.git >> > Branch v1.5.0 (git checkout -b v1.5.0) >> > >> > The KEYS file for signature validation is available at: >> > https://dist.apache.org/repos/dist/release/knox/KEYS >> > >> > KnoxShell User Guide at >> > http://knox.apache.org/books/knox-1-5-0/knoxshell_user_guide.html >> > Gateway User Guide: >> > http://knox.apache.org/books/knox-1-5-0/user-guide.html >> > Dev Guide: http://knox.apache.org/books/knox-1-5-0/dev-guide.html >> > >> > Please vote on releasing this package as Apache Knox 1.5.0. >> > The vote is open for the next 72 hours and passes if a majority of at >> > least three +1 Apache Knox PMC votes are cast. >> > >> > [ ] +1 Release this package as Apache Knox 1.5.0 >> > [ ] -1 Do not release this package because... >> > >> > thanks! >> > >> > --larry >> > >> >
