-----BEGIN PGP SIGNED MESSAGE----- Hash: RIPEMD160 cross-posting for maximum awareness, discussion should be held on dev-list.
Actually the likelyhood of problems is very, very small. BUT you have setup where HTML-files are served as attachments via */path/to/topic/attachment.html* then you need to change those to use the /midcom-serveattachmentguid- stanza. - From IRC he quoteth: [1:40pm] mashiara: heads up people! Related to http://trac.midgard-project.org/ticket/47 a potentially breaking change in http://trac.midgard-project.org/changeset/17715 [1:41pm] mashiara: all components *should* be able to handle this gracefully but if you know your component has some weird functionality that depends on URI having .html then you should change your ways... [1:42pm] mashiara: this does not mean component authors should stay lazy removing those suffixes from the urls they give out [1:43pm] mashiara: since unneccessary 301 is still an unneccessary request and under SSL (especially under IE which behaves badly and thus one must always disable keep-alive in ssl if user-agent looks like IE) extra requests can be costly [1:47pm] bergie: mashiara: note that file attachments with .html suffix should remain valid [1:48pm] mashiara: midcom-somethign methods are unaffected [1:48pm] mashiara: for /path/to/folder/attachment.html we cannot know... [1:49pm] mashiara: and since in 99.99% (possibly even higher percentage) of cases it's not an attachment with .html suffix we just have to accept this [1:50pm] bergie: mashiara: I'm a bit uneasy about fixing this on redirection level *by default* [1:50pm] bergie: maybe a MidCOM config option? [1:51pm] mashiara: me too, however configs are not loaded yet, this is done at the earliest possible point to avoid wasting cycles [1:52pm] mashiara: however based on my hand-waving approximations likelyhood of issues in existing installations is very small [1:53pm] bergie: well... we may be shooting ourselves in the foot here [1:53pm] bergie: but lets try it [1:53pm] bergie: should be easy to revert anyway [1:54pm] mashiara: do you recall any setup where .html files are server as attachments ? [1:54pm] mashiara: does anyone recall any setup ? [1:55pm] mashiara: the next question is what percentage of these are served as /path/to/folder/attachment.html [1:56pm] bergie: mashiara: I remember some sites having .html files as attachments for some pop-ups etc [1:57pm] mashiara: but they're served via midcom-serveattchment [1:57pm] mashiara: which is unaffected [2:00pm] mashiara: the main point is that we can fix a potentially major issue (in-content links behaving differently based on how you happen to land on the page) without requiring co-operation (and duplicated code) from all components [2:01pm] mashiara: with introducing only one arbitary limitation that can be easily worked around [2:01pm] bergie: ok [2:03pm] mashiara: since the default behaviour for imagepopup etc co is to use midcom-serveattachment for attachment serving I'm fairly sure we have no issues from this -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFI3MMQi7iLtQbxbW8RA49oAKCTLQpnCDn/UDzEjXiI2q++JttEFgCbBQTq hczxNTRjsghyivfyCfRYV68= =aOLS -----END PGP SIGNATURE----- _______________________________________________ user mailing list [email protected] http://lists.midgard-project.org/mailman/listinfo/user
