2009/8/26 Andreas Kollegger <akolleg...@tembopublic.org>: > Hi Mattias, > > Thanks for the class. I had started to code up a similar approach when > it occurred to me > that I should first look whether an implementation existed. > > I also would prefer renaming the current implementation to > NeoServiceLifecycleImpl and > adding the interface, but am reluctant to change a published api. > > Would this be disruptive to many people? I don't think so... it's a fairly new class and I don't think many people have found it :) I say go for it. > > On Aug 26, 2009, at 6:19 AM, Mattias Persson wrote: > >> Hi Andreas, >> >> sorry for my non-OSGi skills (the author of this class). >> >> I'd vote for something else, rather than INeoServiceLifecycle since, >> as you pointed out, it'd go against the neo4j conventions. Maybe have >> the interface named NeoServiceLifecycle and the implementation be >> named NeoServiceLifecycleImpl... but that's not the best either, I >> guess, although slightly better... >> >> 2009/8/25 Andreas Kollegger <akolleg...@tembopublic.org>: >>> Hi all, >>> >>> To make NeoServiceLifecycle a bit more digestible in OSGi >>> environments, I'd like to refactor the class into an interface/ >>> implementation pair. To avoid breaking current use of the class, I >>> propose to add an interface above NeoServiceLifecycle which matches >>> the public methods and then make NeoServiceLifecycle implement the >>> interface. >>> >>> The name of the interface could simply be INeoServiceLifecycle -- >>> though that isn't part of the current neo naming scheme. >>> >>> So two things: would people be ok with this change, and what should >>> the interface be called? >>> >>> -Andreas >>> _______________________________________________ >>> Neo mailing list >>> User@lists.neo4j.org >>> https://lists.neo4j.org/mailman/listinfo/user >>> >> >> >> >> -- >> Mattias Persson, [matt...@neotechnology.com] >> Neo Technology, www.neotechnology.com >> _______________________________________________ >> Neo mailing list >> User@lists.neo4j.org >> https://lists.neo4j.org/mailman/listinfo/user > > _______________________________________________ > Neo mailing list > User@lists.neo4j.org > https://lists.neo4j.org/mailman/listinfo/user >
-- Mattias Persson, [matt...@neotechnology.com] Neo Technology, www.neotechnology.com _______________________________________________ Neo mailing list User@lists.neo4j.org https://lists.neo4j.org/mailman/listinfo/user
