On Sat, Oct 30, 2010 at 12:51 PM, Andres Taylor <andres.tay...@neotechnology.com> wrote: > Guys, > > I'm trying to grokk the code. In a couple of places, there are indirections > that I don't understand. Like EmbeddedGraphDatabase, which is, as far as I > can see, mostly a thin wrapper around EmbeddedGraphDatabaseImpl. Why is > this? > > Andrés
I second that. It isn't like there is a factory in EmbeddedGraphDatabase that will provide different implementations of something based on the Config (besides, the read-only vs the full r/w db issue is handled differently). The EmbeddedGraphDatabaseImpl field is hardwired there. I can only assume this was supposed to (or will?) augment the GraphDatabaseService interface with operations other that the EmbeddedGraphDatabaseImpl ones, given that the latter does not implement that. I also have difficulty grasping the EventConsumers concept. They are created in the XaConnection only to be stored in the NioNeoDbPersistenceSource.NioNeoDbResourceConnection and then used to forward calls about primitives. Why is that level of abstraction necessary? I think it would be cleaner and without loss of extensibility for the ResourceConnection to forward directly to the XaConnection. But I admit there are many things happening there, I may be missing something. cheers, CG _______________________________________________ Neo4j mailing list User@lists.neo4j.org https://lists.neo4j.org/mailman/listinfo/user