Ok, this issue has been fixed and backported. I will cut rc2 later today. On Sat, Oct 27, 2018 at 9:53 PM Jie Yu <yujie....@gmail.com> wrote:
> Gilbert, can we fix this and call another vote? > > Thanks, > - Jie > > On Wed, Oct 24, 2018 at 12:45 PM Greg Mann <g...@mesosphere.io> wrote: > >> Hmm I wonder if this is an issue on 1.5.1, or perhaps introduced by this >> commit? https://github.com/apache/mesos/commit/902aa34b79 >> >> On Wed, Oct 24, 2018 at 12:30 PM Vinod Kone <vinodk...@apache.org> wrote: >> >>> -1 >>> >>> Tested on ASF CI. Looks like Clang builds are failing with a build error. >>> See example build output >>> < >>> https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Release/55/BUILDTOOL=autotools,COMPILER=clang,CONFIGURATION=--verbose%20--enable-libevent%20--enable-ssl,ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,OS=ubuntu:14.04,label_exp=(docker%7C%7CHadoop)&&(!ubuntu-us1)&&(!ubuntu-eu2)/console >>> > >>> below: >>> >>> libtool: compile: clang++-3.5 -DPACKAGE_NAME=\"mesos\" >>> -DPACKAGE_TARNAME=\"mesos\" -DPACKAGE_VERSION=\"1.5.2\" >>> "-DPACKAGE_STRING=\"mesos 1.5.2\"" -DPACKAGE_BUGREPORT=\"\" >>> -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" -DVERSION=\"1.5.2\" >>> -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 >>> -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 >>> -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 >>> -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" >>> -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 >>> -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 >>> -DMESOS_HAS_JAVA=1 -DHAVE_EVENT2_EVENT_H=1 -DHAVE_LIBEVENT=1 >>> -DHAVE_EVENT2_THREAD_H=1 -DHAVE_LIBEVENT_PTHREADS=1 -DHAVE_LIBSASL2=1 >>> -DHAVE_OPENSSL_SSL_H=1 -DHAVE_EVENT2_BUFFEREVENT_SSL_H=1 >>> -DHAVE_LIBEVENT_OPENSSL=1 -DUSE_SSL_SOCKET=1 -DHAVE_SVN_VERSION_H=1 >>> -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 >>> -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" >>> -DMESOS_HAS_PYTHON=1 -I. -I../../src -Werror >>> -DLIBDIR=\"/mesos/mesos-1.5.2/_inst/lib\" >>> -DPKGLIBEXECDIR=\"/mesos/mesos-1.5.2/_inst/libexec/mesos\" >>> -DPKGDATADIR=\"/mesos/mesos-1.5.2/_inst/share/mesos\" >>> -DPKGMODULEDIR=\"/mesos/mesos-1.5.2/_inst/lib/mesos/modules\" >>> -I../../include -I../include -I../include/mesos -DPICOJSON_USE_INT64 >>> -D__STDC_FORMAT_MACROS -isystem ../3rdparty/boost-1.53.0 -isystem >>> ../3rdparty/concurrentqueue-7b69a8f -I../3rdparty/elfio-3.2 >>> -I../3rdparty/glog-0.3.3/src -I../3rdparty/leveldb-1.19/include >>> -I../../3rdparty/libprocess/include -I../3rdparty/nvml-352.79 >>> -I../3rdparty/picojson-1.3.0 -I../3rdparty/protobuf-3.5.0/src >>> -I../../3rdparty/stout/include >>> -I../3rdparty/zookeeper-3.4.8/src/c/include >>> -I../3rdparty/zookeeper-3.4.8/src/c/generated -isystem >>> /usr/include/subversion-1 -isystem /usr/include/apr-1 -isystem >>> /usr/include/apr-1.0 -pthread -Wall -Wsign-compare -Wformat-security >>> -fstack-protector-strong -fPIC -g1 -O0 -std=c++11 -MT >>> slave/containerizer/libmesos_no_3rdparty_la-containerizer.lo -MD -MP >>> -MF slave/containerizer/.deps/libmesos_no_3rdparty_la-containerizer.Tpo >>> -c ../../src/slave/containerizer/containerizer.cpp -fPIC -DPIC -o >>> slave/containerizer/.libs/libmesos_no_3rdparty_la-containerizer.o >>> In file included from ../../src/slave/http.cpp:30: >>> In file included from ../../include/mesos/authorizer/authorizer.hpp:25: >>> ../../3rdparty/libprocess/include/process/future.hpp:1089:3: error: no >>> matching member function for call to 'set' >>> set(u); >>> ^~~ >>> ../../src/slave/http.cpp:3196:10: note: in instantiation of function >>> template specialization >>> 'process::Future<process::http::Response>::Future<process::Future<const >>> process::Future<process::http::Response> > >' requested here >>> return slave->containerizer->attach(containerId) >>> ^ >>> ../../3rdparty/libprocess/include/process/future.hpp:597:8: note: >>> candidate function not viable: no known conversion from 'const >>> process::Future<const process::Future<process::http::Response> >' to >>> 'const process::http::Response' for 1st argument >>> bool set(const T& _t); >>> ^ >>> ../../3rdparty/libprocess/include/process/future.hpp:598:8: note: >>> candidate function not viable: no known conversion from 'const >>> process::Future<const process::Future<process::http::Response> >' to >>> 'process::http::Response' for 1st argument >>> bool set(T&& _t); >>> ^ >>> >>> >>> >>> >>> >>> >>> >>> On Mon, Oct 22, 2018 at 12:53 AM Gilbert Song <gilb...@apache.org> >>> wrote: >>> >>> > Hi all, >>> > >>> > Please vote on releasing the following candidate as Apache Mesos 1.5.2. >>> > >>> > 1.5.2 includes the following: >>> > >>> > >>> -------------------------------------------------------------------------------- >>> > * [MESOS-3790] - ZooKeeper connection should retry on `EAI_NONAME`. >>> > * [MESOS-8128] - Make os::pipe file descriptors O_CLOEXEC. >>> > * [MESOS-8418] - mesos-agent high cpu usage because of numerous >>> > /proc/mounts reads. >>> > * [MESOS-8545] - >>> > AgentAPIStreamingTest.AttachInputToNestedContainerSession is flaky. >>> > * [MESOS-8568] - Command checks should always call >>> > `WAIT_NESTED_CONTAINER` before `REMOVE_NESTED_CONTAINER`. >>> > * [MESOS-8620] - Containers stuck in FETCHING possibly due to >>> > unresponsive server. >>> > * [MESOS-8830] - Agent gc on old slave sandboxes could empty >>> persistent >>> > volume data. >>> > * [MESOS-8871] - Agent may fail to recover if the agent dies before >>> > image store cache checkpointed. >>> > * [MESOS-8904] - Master crash when removing quota. >>> > * [MESOS-8906] - `UriDiskProfileAdaptor` fails to update profile >>> > selectors. >>> > * [MESOS-8917] - Agent leaking file descriptors into forked >>> processes. >>> > * [MESOS-8921] - Autotools don't work with newer OpenJDK versions. >>> > * [MESOS-8935] - Quota limit "chopping" can lead to cpu-only and >>> > memory-only offers. >>> > * [MESOS-8936] - Implement a Random Sorter for offer allocations. >>> > * [MESOS-8942] - Master streaming API does not send (health) check >>> > updates for tasks. >>> > * [MESOS-8945] - Master check failure due to CHECK_SOME(providerId). >>> > * [MESOS-8947] - Improve the container preparing logging in >>> > IOSwitchboard and volume/secret isolator. >>> > * [MESOS-8952] - process::await/collect n^2 performance issue. >>> > * [MESOS-8963] - Executor crash trying to print container ID. >>> > * [MESOS-8978] - Command executor calling setsid breaks the tty >>> support. >>> > * [MESOS-8980] - mesos-slave can deadlock with docker pull. >>> > * [MESOS-8986] - `slave.available()` in the allocator is expensive >>> and >>> > drags down allocation performance. >>> > * [MESOS-8987] - Master asks agent to shutdown upon auth errors. >>> > * [MESOS-9024] - Mesos master segfaults with stack overflow under >>> load. >>> > * [MESOS-9049] - Agent GC could unmount a dangling persistent volume >>> > multiple times. >>> > * [MESOS-9116] - Launch nested container session fails due to >>> incorrect >>> > detection of `mnt` namespace of command executor's task. >>> > * [MESOS-9125] - Port mapper CNI plugin might fail with "Resource >>> > temporarily unavailable". >>> > * [MESOS-9127] - Port mapper CNI plugin might deadlock iptables on >>> the >>> > agent. >>> > * [MESOS-9131] - Health checks launching nested containers while a >>> > container is being destroyed lead to unkillable tasks. >>> > * [MESOS-9142] - CNI detach might fail due to missing network config >>> > file. >>> > * [MESOS-9144] - Master authentication handling leads to request >>> > amplification. >>> > * [MESOS-9145] - Master has a fragile burned-in 5s authentication >>> > timeout. >>> > * [MESOS-9146] - Agent has a fragile burn-in 5s authentication >>> timeout. >>> > * [MESOS-9147] - Agent and scheduler driver authentication retry >>> backoff >>> > time could overflow. >>> > * [MESOS-9151] - Container stuck at ISOLATING due to FD leak. >>> > * [MESOS-9170] - Zookeeper doesn't compile with newer gcc due to >>> format >>> > error. >>> > * [MESOS-9196] - Removing rootfs mounts may fail with EBUSY. >>> > * [MESOS-9231] - `docker inspect` may return an unexpected result to >>> > Docker executor due to a race condition. >>> > * [MESOS-9267] - Mesos agent crashes when CNI network is not >>> configured >>> > but used. >>> > * [MESOS-9279] - Docker Containerizer 'usage' call might be >>> expensive if >>> > mount table is big. >>> > * [MESOS-9283] - Docker containerizer actor can get backlogged with >>> > large number of containers. >>> > * [MESOS-9308] - URI disk profile adaptor could deadlock. >>> > >>> > The CHANGELOG for the release is available at: >>> > >>> > >>> https://gitbox.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=1.5.2-rc1 >>> > >>> > >>> -------------------------------------------------------------------------------- >>> > >>> > The candidate for Mesos 1.5.2 release is available at: >>> > >>> https://dist.apache.org/repos/dist/dev/mesos/1.5.2-rc1/mesos-1.5.2.tar.gz >>> > >>> > The tag to be voted on is 1.5.2-rc1: >>> > https://gitbox.apache.org/repos/asf?p=mesos.git;a=commit;h=1.5.2-rc1 >>> > >>> > The SHA512 checksum of the tarball can be found at: >>> > >>> > >>> https://dist.apache.org/repos/dist/dev/mesos/1.5.2-rc1/mesos-1.5.2.tar.gz.sha512 >>> > >>> > The signature of the tarball can be found at: >>> > >>> > >>> https://dist.apache.org/repos/dist/dev/mesos/1.5.2-rc1/mesos-1.5.2.tar.gz.asc >>> > >>> > The PGP key used to sign the release is here: >>> > https://dist.apache.org/repos/dist/release/mesos/KEYS >>> > >>> > The JAR is in a staging repository here: >>> > https://repository.apache.org/content/repositories/orgapachemesos-1238 >>> > >>> > Please vote on releasing this package as Apache Mesos 1.5.2! >>> > >>> > The vote is open until Wed Oct 24 23:59:00 PDT 2018 and passes if a >>> > majority of at least 3 +1 PMC votes are cast. >>> > >>> > [ ] +1 Release this package as Apache Mesos 1.5.2 >>> > [ ] -1 Do not release this package because ... >>> > >>> > Thanks, >>> > Gilbert >>> > >>> >>
