+1 (binding) Thanks for looking into it. Lets fix this in a point release.
On Tue, May 26, 2020 at 8:31 AM Andrei Sekretenko <asekrete...@mesosphere.io> wrote: > Thanks for checking this! > > The first one (centos, non-SSL, gcc, autotools) seems to be a race between > several instances of `javah` attempting to check for existence and create > the output directory. > I believe there were no related changes in 1.10.x compared to 1.9.x. > > The second one (ubuntu, SSL, clang, autotools) is somewhat tricky. > The immediate cause of the failure seems to be an attempt to compile > src/tests/http_tests.proto with a not yet built protoc. > src/tests/http_tests.proto has been added in 1.10; there were no > tests-only protobuf definitions in Mesos before that. > However, I'm not quite getting how protobuf compilation in the automake > build is supposed to work at all with a bundled protoc. > > When the bundled protobuf is used, I don't see any dependency on protoc > injected into the pb.cc/pb.h targets in the generated Makefile. > Neither do I see how src/Makefile.am is supposed to introduce this > dependency. > (See > https://github.com/apache/mesos/blob/5a04a1693e4f1d51007c23728f1884a307e22src/testssrc/tests9a1/src/Makefile.am#L499 > <https://github.com/apache/mesos/blob/5a04a1693e4f1d51007c23728f1884a307e229a1/src/Makefile.am#L499> > and below). > Looks like all other protobufs (usually?) compile due to sheer luck. > > The workaround for the javah race and the fix for missing dependency on > protoc seem to be rather straightforward. > If any of these two should be considered a blocker for 1.10.0, please vote > -1. > > > > > > On Tue, May 19, 2020 at 6:55 PM Vinod Kone <vinodk...@apache.org> wrote: > >> Ran it in Apache CI. Found 2 build issues (issue 1 >> <https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Release/77/BUILDTOOL=autotools,COMPILER=gcc,CONFIGURATION=--verbose%20--disable-libtool-wrappers%20--disable-parallel-test-execution,ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,OS=centos%3A7,label_exp=(docker%7C%7CHadoop%7C%7Cbeam)&&(!ubuntu-us1)&&(!ubuntu-eu2)/console>, >> issue 2 >> <https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Release/77/BUILDTOOL=autotools,COMPILER=clang,CONFIGURATION=--verbose%20--disable-libtool-wrappers%20--disable-parallel-test-execution%20--enable-libevent%20--enable-ssl,ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,OS=ubuntu%3A16.04,label_exp=(docker%7C%7CHadoop%7C%7Cbeam)&&(!ubuntu-us1)&&(!ubuntu-eu2)/console>) >> which seem to be related to race condition due to parallel build. >> >> @Andrei Sekretenko <asekrete...@mesosphere.io> Can you confirm this is >> not a regression in the build system? >> >> *Revision*: 1fb36dcc5a0099f147cd01bd82cd7b4f0aec2256 >> >> - refs/tags/1.10.0-rc1 >> >> Configuration Matrix gcc clang >> centos:7 --verbose --disable-libtool-wrappers >> --disable-parallel-test-execution --enable-libevent --enable-ssl >> autotools >> [image: Success] >> <https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Release/77/BUILDTOOL=autotools,COMPILER=gcc,CONFIGURATION=--verbose%20--disable-libtool-wrappers%20--disable-parallel-test-execution%20--enable-libevent%20--enable-ssl,ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,OS=centos%3A7,label_exp=(docker%7C%7CHadoop%7C%7Cbeam)&&(!ubuntu-us1)&&(!ubuntu-eu2)/> >> [image: Not run] >> cmake >> [image: Success] >> <https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Release/77/BUILDTOOL=cmake,COMPILER=gcc,CONFIGURATION=--verbose%20--disable-libtool-wrappers%20--disable-parallel-test-execution%20--enable-libevent%20--enable-ssl,ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,OS=centos%3A7,label_exp=(docker%7C%7CHadoop%7C%7Cbeam)&&(!ubuntu-us1)&&(!ubuntu-eu2)/> >> [image: Not run] >> --verbose --disable-libtool-wrappers --disable-parallel-test-execution >> autotools >> [image: Failed] >> <https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Release/77/BUILDTOOL=autotools,COMPILER=gcc,CONFIGURATION=--verbose%20--disable-libtool-wrappers%20--disable-parallel-test-execution,ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,OS=centos%3A7,label_exp=(docker%7C%7CHadoop%7C%7Cbeam)&&(!ubuntu-us1)&&(!ubuntu-eu2)/> >> [image: Not run] >> cmake >> [image: Success] >> <https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Release/77/BUILDTOOL=cmake,COMPILER=gcc,CONFIGURATION=--verbose%20--disable-libtool-wrappers%20--disable-parallel-test-execution,ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,OS=centos%3A7,label_exp=(docker%7C%7CHadoop%7C%7Cbeam)&&(!ubuntu-us1)&&(!ubuntu-eu2)/> >> [image: Not run] >> ubuntu:16.04 --verbose --disable-libtool-wrappers >> --disable-parallel-test-execution --enable-libevent --enable-ssl >> autotools >> [image: Success] >> <https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Release/77/BUILDTOOL=autotools,COMPILER=gcc,CONFIGURATION=--verbose%20--disable-libtool-wrappers%20--disable-parallel-test-execution%20--enable-libevent%20--enable-ssl,ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,OS=ubuntu%3A16.04,label_exp=(docker%7C%7CHadoop%7C%7Cbeam)&&(!ubuntu-us1)&&(!ubuntu-eu2)/> >> [image: Failed] >> <https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Release/77/BUILDTOOL=autotools,COMPILER=clang,CONFIGURATION=--verbose%20--disable-libtool-wrappers%20--disable-parallel-test-execution%20--enable-libevent%20--enable-ssl,ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,OS=ubuntu%3A16.04,label_exp=(docker%7C%7CHadoop%7C%7Cbeam)&&(!ubuntu-us1)&&(!ubuntu-eu2)/> >> cmake >> [image: Success] >> <https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Release/77/BUILDTOOL=cmake,COMPILER=gcc,CONFIGURATION=--verbose%20--disable-libtool-wrappers%20--disable-parallel-test-execution%20--enable-libevent%20--enable-ssl,ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,OS=ubuntu%3A16.04,label_exp=(docker%7C%7CHadoop%7C%7Cbeam)&&(!ubuntu-us1)&&(!ubuntu-eu2)/> >> [image: Success] >> <https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Release/77/BUILDTOOL=cmake,COMPILER=clang,CONFIGURATION=--verbose%20--disable-libtool-wrappers%20--disable-parallel-test-execution%20--enable-libevent%20--enable-ssl,ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,OS=ubuntu%3A16.04,label_exp=(docker%7C%7CHadoop%7C%7Cbeam)&&(!ubuntu-us1)&&(!ubuntu-eu2)/> >> --verbose --disable-libtool-wrappers --disable-parallel-test-execution >> autotools >> [image: Success] >> <https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Release/77/BUILDTOOL=autotools,COMPILER=gcc,CONFIGURATION=--verbose%20--disable-libtool-wrappers%20--disable-parallel-test-execution,ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,OS=ubuntu%3A16.04,label_exp=(docker%7C%7CHadoop%7C%7Cbeam)&&(!ubuntu-us1)&&(!ubuntu-eu2)/> >> [image: Success] >> <https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Release/77/BUILDTOOL=autotools,COMPILER=clang,CONFIGURATION=--verbose%20--disable-libtool-wrappers%20--disable-parallel-test-execution,ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,OS=ubuntu%3A16.04,label_exp=(docker%7C%7CHadoop%7C%7Cbeam)&&(!ubuntu-us1)&&(!ubuntu-eu2)/> >> cmake >> [image: Success] >> <https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Release/77/BUILDTOOL=cmake,COMPILER=gcc,CONFIGURATION=--verbose%20--disable-libtool-wrappers%20--disable-parallel-test-execution,ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,OS=ubuntu%3A16.04,label_exp=(docker%7C%7CHadoop%7C%7Cbeam)&&(!ubuntu-us1)&&(!ubuntu-eu2)/> >> [image: Success] >> <https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Release/77/BUILDTOOL=cmake,COMPILER=clang,CONFIGURATION=--verbose%20--disable-libtool-wrappers%20--disable-parallel-test-execution,ENVIRONMENT=GLOG_v=1%20MESOS_VERBOSE=1,OS=ubuntu%3A16.04,label_exp=(docker%7C%7CHadoop%7C%7Cbeam)&&(!ubuntu-us1)&&(!ubuntu-eu2)/> >> >> >> >> On Mon, May 18, 2020 at 3:36 PM Andrei Sekretenko <asekrete...@d2iq.com> >> wrote: >> >>> Hi all, >>> >>> Please vote on releasing the following candidate as Apache Mesos 1.10.0. >>> >>> 1.10.0 includes the following major improvements: >>> >>> -------------------------------------------------------------------------------- >>> * support for resource bursting (setting task resource limits separately >>> from requests) on Linux >>> * ability for an executor to communicate with an agent via Unix domain >>> socket instead of TCP >>> * ability for operators to modify reservations via the RESERVE_RESOURCES >>> master API call >>> * performance improvements of V1 operator API read-only calls bringing >>> them on par with V0 HTTP endpoints >>> * ability for a scheduler to expect that effects of calls sent through >>> the same connection will not be reordered/interleaved by master >>> >>> NOTE: 1.10.0 includes a breaking change for custom authorizer modules. >>> Now, `ObjectApprover`s may be stored by Mesos indefinitely and must be >>> kept up-to-date by an authorizer throughout their lifetime. >>> This allowed for several bugfixes and performance improvements. >>> >>> The CHANGELOG for the release is available at: >>> >>> https://gitbox.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=1.10.0-rc1 >>> >>> -------------------------------------------------------------------------------- >>> >>> The candidate for Mesos 1.10.0 release is available at: >>> >>> https://dist.apache.org/repos/dist/dev/mesos/1.10.0-rc1/mesos-1.10.0.tar.gz >>> >>> The tag to be voted on is 1.10.0-rc1: >>> https://gitbox.apache.org/repos/asf?p=mesos.git;a=commit;h=1.10.0-rc1 >>> >>> The SHA512 checksum of the tarball can be found at: >>> >>> https://dist.apache.org/repos/dist/dev/mesos/1.10.0-rc1/mesos-1.10.0.tar.gz.sha512 >>> >>> The signature of the tarball can be found at: >>> >>> https://dist.apache.org/repos/dist/dev/mesos/1.10.0-rc1/mesos-1.10.0.tar.gz.asc >>> >>> The PGP key used to sign the release is here: >>> https://dist.apache.org/repos/dist/release/mesos/KEYS >>> >>> The JAR is in a staging repository here: >>> https://repository.apache.org/content/repositories/orgapachemesos-1259 >>> >>> Please vote on releasing this package as Apache Mesos 1.10.0! >>> >>> The vote is open until Fri, May 21, 19:00 CEST and passes if a majority >>> of at least 3 +1 PMC votes are cast. >>> >>> [ ] +1 Release this package as Apache Mesos 1.10.0 >>> [ ] -1 Do not release this package because ... >>> >>> Thanks, >>> Andrei Sekretenko >>> >> > > -- > -- > Andrei Sekretenko >
