I had this problem using svn head for 1 week ago. Tracking it down, I
found that I have the problem using revision from 16.jan 1200, but the
problem is not there 17.jan 1200.
I have attached a diff between the two revisions. I notice a version
change in the plugin/pom.xml for the jar plugin dependency. Thats
probably why.
Anyway, it seems like the svn head builds fine now. Have not tried
actually using this version yet.
Rohnny
On Jan 19, 2008 12:01 PM, Jerome Lacoste <[EMAIL PROTECTED]> wrote:
> I am trying to investigate the compilation failure several users
> reported on the trunk of the webstart maven plugin. See
> http://jira.codehaus.org/browse/MWEBSTART-82 and
> http://jira.codehaus.org/browse/MWEBSTART-93.
> I am having a hard time trying to reproduce it.
>
> I've tried maven 2.0.6, 2.0.7 and 2.0.8 under Linux with JDK 1.5.0_11-b03.
>
> Each time I did:
>
> svn up
> svn revert -R .
> rm -r ~/.m2/repository
> mvn clean install
>
> In each case, the build passed.
>
> Users have reported the issue under various configurations.
>
> Maven version: 2.0.7
> Java version: 1.6.0_01
> OS name: "linux" version: "2.6.17-12-generic" arch: "i386"
>
> Maven version: 2.0.7
> Java version: 1.5.0_14
> OS name: "windows xp" version: "5.1" arch: "x86"
>
> Maven 2.0.8
> JDK 1.5.0_04-b05
> OS unknown
>
>
>
> My settings.xml doesn't contain any mirror, proxy or anything.
>
> To those having problems, do you have anything in your settings.xml
> that could affect this issue ?
> Can you produce a debug build log ?
>
> To others, any idea what could affect the reproducibility of the build ?
>
> Thanks.
>
> Jerome
>
> ---------------------------------------------------------------------
> To unsubscribe from this list please visit:
>
> http://xircles.codehaus.org/manage_email
>
>
Index: plugin/src/main/java/org/codehaus/mojo/webstart/AbstractBaseJnlpMojo.java
===================================================================
--- plugin/src/main/java/org/codehaus/mojo/webstart/AbstractBaseJnlpMojo.java (revision 5937)
+++ plugin/src/main/java/org/codehaus/mojo/webstart/AbstractBaseJnlpMojo.java (revision 5940)
@@ -52,6 +52,9 @@
private static final String DEFAULT_RESOURCES_DIR = "src/main/jnlp/resources";
+ /** unprocessed files (that will be signed) are prefixed with this */
+ private static final String UNPROCESSED_PREFIX = "unprocessed_";
+
/**
* Artifact resolver, needed to download source jars for inclusion in classpath.
*
@@ -156,7 +159,7 @@
private final List modifiedJnlpArtifacts = new ArrayList();
- // the jars to sign and pack are selected if they are suffixed by .unprocessed.
+ // the jars to sign and pack are selected if they are prefixed by UNPROCESSED_PREFIX.
// as the plugin copies the new versions locally before signing/packing them
// we just need to see if the plugin copied a new version
// We achieve that by only filtering files modified after the plugin was started
@@ -191,7 +194,8 @@
public boolean accept( File pathname )
{
- return pathname.isFile() && pathname.getName().endsWith( ".jar" );
+ return pathname.isFile() && pathname.getName().endsWith( ".jar" )
+ && ! pathname.getName().startsWith( UNPROCESSED_PREFIX );
}
};
@@ -200,7 +204,8 @@
public boolean accept( File pathname )
{
- return pathname.isFile() && pathname.getName().endsWith( ".jar.unprocessed" );
+ return pathname.isFile() && pathname.getName().startsWith( UNPROCESSED_PREFIX )
+ && pathname.getName().endsWith( ".jar" );
}
};
@@ -517,8 +522,8 @@
/**
* Conditionally copy the jar file into the target directory.
* The operation is not performed when a signed target file exists and is up to date.
- * The signed target file name is taken from the <code>sourceFile</code> name.
- * The unsigned target file name is taken from the <code>sourceFile</code> name suffixed with ".unprocessed".
+ * The signed target file name is taken from the <code>sourceFile</code> name.E
+ * The unsigned target file name is taken from the <code>sourceFile</code> name prefixed with UNPROCESSED_PREFIX.
* TODO this is confusing if the sourceFile is already signed. By unsigned we really mean 'unsignedbyus'
*
* @return <code>true</code> when the file was copied, <code>false</code> otherwise.
@@ -536,7 +541,7 @@
File signedTargetFile = new File( targetDirectory, sourceFile.getName() );
- File unsignedTargetFile = new File( targetDirectory, sourceFile.getName() + ".unprocessed" );
+ File unsignedTargetFile = new File( targetDirectory, UNPROCESSED_PREFIX + sourceFile.getName() );
boolean shouldCopy = ! signedTargetFile.exists() || ( signedTargetFile.lastModified() < sourceFile.lastModified() );
@@ -600,38 +605,38 @@
private int makeUnprocessedFilesFinal( File directory, FileFilter fileFilter ) throws MojoExecutionException
{
- File[] files = directory.listFiles( fileFilter );
+ File[] jarFiles = directory.listFiles( fileFilter );
if ( getLog().isDebugEnabled() )
{
- getLog().debug( "makeUnprocessedFilesFinal in " + directory + " found " + files.length + " file(s) to rename" );
+ getLog().debug( "makeUnprocessedFilesFinal in " + directory + " found " + jarFiles.length + " file(s) to rename" );
}
- if ( files.length == 0 )
+ if ( jarFiles.length == 0 )
{
return 0;
}
- for ( int i = 0; i < files.length; i++ )
+ for ( int i = 0; i < jarFiles.length; i++ )
{
- // FIXME refactor with signJars
- String unprocessedJarFilePath = files[i].getAbsolutePath();
- if (!unprocessedJarFilePath.endsWith( ".unprocessed" )) {
- throw new IllegalStateException( "We are about to rename an non .unprocessed file with path: " + unprocessedJarFilePath );
+ String unprocessedJarFileName = jarFiles[i].getName();
+ if (!unprocessedJarFileName.startsWith( UNPROCESSED_PREFIX )) {
+ throw new IllegalStateException( "We are about to sign an non " + UNPROCESSED_PREFIX
+ + " file with path: " + jarFiles[i].getAbsolutePath() );
}
- File finalJar = new File( unprocessedJarFilePath.substring( 0, unprocessedJarFilePath.length() - ".unprocessed".length() ) );
+ File finalJar = new File( jarFiles[i].getParent(), unprocessedJarFileName.substring( UNPROCESSED_PREFIX.length() ) );
if ( finalJar.exists() ) {
boolean deleted = finalJar.delete();
if (! deleted) {
throw new IllegalStateException( "Couldn't delete obsolete final jar: " + finalJar.getAbsolutePath() );
}
}
- boolean renamed = files[i].renameTo( finalJar );
+ boolean renamed = jarFiles[i].renameTo( finalJar );
if (! renamed) {
throw new IllegalStateException( "Couldn't rename into final jar: " + finalJar.getAbsolutePath() );
}
}
- return files.length;
+ return jarFiles.length;
}
/**
@@ -683,12 +688,13 @@
for ( int i = 0; i < jarFiles.length; i++ )
{
- String unprocessedJarFilePath = jarFiles[i].getAbsolutePath();
- if (!unprocessedJarFilePath.endsWith( ".unprocessed" )) {
- throw new IllegalStateException( "We are about to sign an non .unprocessed file with path: " + unprocessedJarFilePath );
+ String unprocessedJarFileName = jarFiles[i].getName();
+ if (!unprocessedJarFileName.startsWith( UNPROCESSED_PREFIX )) {
+ throw new IllegalStateException( "We are about to sign an non " + UNPROCESSED_PREFIX
+ + " file with path: " + jarFiles[i].getAbsolutePath() );
}
jarSigner.setJarPath( jarFiles[i] );
- File signedJar = new File( unprocessedJarFilePath.substring( 0, unprocessedJarFilePath.length() - ".unprocessed".length() ) );
+ File signedJar = new File( jarFiles[i].getParent(), unprocessedJarFileName.substring( UNPROCESSED_PREFIX.length() ) );
jarSigner.setSignedJar( signedJar );
if ( signedJar.exists() ) {
boolean deleted = signedJar.delete();
@@ -696,10 +702,8 @@
throw new IllegalStateException( "Couldn't delete obsolete signed jar: " + signedJar.getAbsolutePath() );
}
}
- // long lastModified = unprocessedJarFilePath.lastModified();
jarSigner.execute();
getLog().debug( "lastModified signedJar:" + signedJar.lastModified() + " unprocessed signed Jar:" + jarFiles[i].lastModified() );
- //setLastModified( jarFiles[i], lastModified );
// remove unprocessed files
// TODO wouldn't have to do that if we copied the unprocessed jar files in a temporary area
@@ -934,7 +938,8 @@
public boolean accept( File pathname )
{
return pathname.isFile() &&
- ( pathname.getName().endsWith( ".jar.unprocessed.pack.gz" ) || pathname.getName().endsWith( ".jar.unprocessed.pack" ) );
+ pathname.getName().startsWith( UNPROCESSED_PREFIX ) &&
+ ( pathname.getName().endsWith( ".jar.pack.gz" ) || pathname.getName().endsWith( ".jar.pack" ) );
}
};
Index: plugin/src/it/it003/webapp/pom.xml
===================================================================
--- plugin/src/it/it003/webapp/pom.xml (revision 5937)
+++ plugin/src/it/it003/webapp/pom.xml (revision 5940)
@@ -45,11 +45,6 @@
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>webstart-maven-plugin</artifactId>
- <!--
- Due to incomplete alpha-status a patched snapshot version is used.
- * maven-webstart-plugin (revision 5700
- + patch http://jira.codehaus.org/browse/MWEBSTART-63 "MWEBSTART-63-patch.diff")
- -->
<version>testing</version>
<executions>
<execution>
Index: plugin/src/it/it006/sign-one/src/main/java/org/mycompany/webstart/HelloWorld.java
===================================================================
--- plugin/src/it/it006/sign-one/src/main/java/org/mycompany/webstart/HelloWorld.java (revision 0)
+++ plugin/src/it/it006/sign-one/src/main/java/org/mycompany/webstart/HelloWorld.java (revision 5940)
@@ -0,0 +1,13 @@
+package org.mycompany.webstart;
+
+/**
+ * Hello world!
+ *
+ */
+public class HelloWorld
+{
+ public static void main( String[] args )
+ {
+ System.out.println( "Hello World!" );
+ }
+}
Index: plugin/src/it/it006/sign-one/pom.xml
===================================================================
--- plugin/src/it/it006/sign-one/pom.xml (revision 0)
+++ plugin/src/it/it006/sign-one/pom.xml (revision 5940)
@@ -0,0 +1,58 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";>
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.codehaus.mojo.webstart.it006</groupId>
+ <artifactId>webstart-it006-parent</artifactId>
+ <version>1.0</version>
+ </parent>
+
+ <artifactId>sign-one</artifactId>
+ <packaging>jar</packaging>
+ <version>1.0</version>
+ <name>Core Module</name>
+ <url>http://maven.apache.org</url>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>keytool-maven-plugin</artifactId>
+ <version>1.0-beta-1</version>
+ <executions>
+ <execution>
+ <goals>
+ <goal>genkey</goal>
+ </goals>
+ <phase>validate</phase> <!-- should really be pre-package... -->
+ </execution>
+ </executions>
+ <configuration>
+ <alias>webstart-plugin</alias>
+ <keystore>${project.build.directory}/tmpkeystore</keystore>
+ <dname>cn=www.example.com, ou=None, L=Seattle, ST=Washington, o=ExampleOrg, c=US</dname>
+ <storepass>foobar2</storepass>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-jar-plugin</artifactId>
+ <executions>
+ <execution>
+ <goals>
+ <goal>sign</goal>
+ </goals>
+ </execution>
+ </executions>
+ <configuration>
+ <keystore>${project.build.directory}/tmpkeystore</keystore>
+ <alias>webstart-plugin</alias>
+ <storepass>foobar2</storepass>
+ <verify>true</verify>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+
+</project>
Index: plugin/src/it/it006/goals.txt
===================================================================
--- plugin/src/it/it006/goals.txt (revision 0)
+++ plugin/src/it/it006/goals.txt (revision 5940)
@@ -0,0 +1 @@
+clean install
Index: plugin/src/it/it006/pom.xml
===================================================================
--- plugin/src/it/it006/pom.xml (revision 0)
+++ plugin/src/it/it006/pom.xml (revision 5940)
@@ -0,0 +1,17 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";>
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>org.codehaus.mojo.webstart.it006</groupId>
+ <artifactId>webstart-it006-parent</artifactId>
+ <version>1.0</version>
+ <packaging>pom</packaging>
+ <name>Webstart it006</name>
+ <description>Webstart JNLP to test unsigning of signed dependencies before signing. The first module creates a signed dependency reused in the second module.</description>
+
+ <modules>
+ <module>sign-one</module>
+ <module>webstart</module>
+ </modules>
+
+</project>
Index: plugin/src/it/it006/webstart/src/main/jnlp/jnlpTemplate.vm
===================================================================
--- plugin/src/it/it006/webstart/src/main/jnlp/jnlpTemplate.vm (revision 0)
+++ plugin/src/it/it006/webstart/src/main/jnlp/jnlpTemplate.vm (revision 5940)
@@ -0,0 +1,28 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Java Webstart JNLP Velocity Template for use with Webstart Maven Plugin -->
+<jnlp
+ spec="1.0+"
+ codebase="$$codebase"
+ context="$$context"
+ href="$$name">
+ <information>
+ <title>${informationTitle}</title>
+ <vendor>${informationVendor}</vendor>
+ <homepage href="${informationHomepage}"/>
+ <description>${informationDescription}</description>
+ <icon href="images/icon.gif"/>
+ <offline-allowed/>
+ <shortcut online="true">
+ <desktop/> <!-- create shortcut on desktop -->
+ <menu submenu="${informationVendor}"/> <!-- create shortcut in startmenu -->
+ </shortcut>
+ </information>
+ <security>
+ <all-permissions/>
+ </security>
+ <resources>
+ <j2se version="1.5+" /> <!-- define required Java runtime version -->
+ $dependencies
+ </resources>
+ <application-desc main-class="$mainClass"/>
+</jnlp>
Index: plugin/src/it/it006/webstart/src/main/webapp/index.jsp
===================================================================
--- plugin/src/it/it006/webstart/src/main/webapp/index.jsp (revision 0)
+++ plugin/src/it/it006/webstart/src/main/webapp/index.jsp (revision 5940)
@@ -0,0 +1,16 @@
+<html>
+<body>
+<h2>Hello World!</h2>
+
+<div>
+ <h3>Get HelloWorld-App</h3>
+ <ul>
+ <li>
+ Download and start the HelloWorld-application via Java WebStart:
+ <a href="webstart/launch.jnlp">Start HelloWorld</a>
+ </li>
+ </ul>
+</div>
+
+</body>
+</html>
Index: plugin/src/it/it006/webstart/src/main/webapp/WEB-INF/web.xml
===================================================================
--- plugin/src/it/it006/webstart/src/main/webapp/WEB-INF/web.xml (revision 0)
+++ plugin/src/it/it006/webstart/src/main/webapp/WEB-INF/web.xml (revision 5940)
@@ -0,0 +1,18 @@
+<!DOCTYPE web-app PUBLIC
+ "-//Sun Microsystems, Inc.//DTD Web Application 2.3//EN"
+ "http://java.sun.com/dtd/web-app_2_3.dtd"; >
+
+<web-app>
+ <display-name>Webstart Demo Application</display-name>
+
+ <servlet>
+ <servlet-name>JnlpDownloadServlet</servlet-name>
+ <servlet-class>jnlp.sample.servlet.JnlpDownloadServlet</servlet-class>
+ </servlet>
+
+ <servlet-mapping>
+ <servlet-name>JnlpDownloadServlet</servlet-name>
+ <url-pattern>/webstart/*</url-pattern>
+ </servlet-mapping>
+
+</web-app>
Index: plugin/src/it/it006/webstart/pom.xml
===================================================================
--- plugin/src/it/it006/webstart/pom.xml (revision 0)
+++ plugin/src/it/it006/webstart/pom.xml (revision 5940)
@@ -0,0 +1,99 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";>
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.codehaus.mojo.webstart.it003</groupId>
+ <artifactId>webstart-it003-parent</artifactId>
+ <version>1.0</version>
+ </parent>
+
+ <artifactId>webapp</artifactId>
+ <packaging>war</packaging>
+ <version>1.0</version>
+ <name>WebstartDemoWebApplication</name>
+ <url>http://maven.apache.org</url>
+
+ <description>
+ Web-application to demonstrate the WebstartMavenPlugin.
+ </description>
+
+
+ <organization>
+ <name>MyCompany</name>
+ <url>http://www.mycompany.org</url>
+ </organization>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.codehaus.mojo.webstart.it006</groupId>
+ <artifactId>sign-one</artifactId>
+ <version>1.0</version>
+ <scope>runtime</scope>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>webstart-maven-plugin</artifactId>
+ <version>testing</version>
+ <executions>
+ <execution>
+ <phase>process-resources</phase>
+ <goals>
+ <goal>jnlp-download-servlet</goal>
+ </goals>
+ </execution>
+ </executions>
+
+ <configuration>
+ <outputDirectoryName>webstart</outputDirectoryName>
+ <jnlpFiles>
+ <jnlpFile>
+ <templateFilename>jnlpTemplate.vm</templateFilename>
+ <outputFilename>launch1.jnlp</outputFilename>
+ <jarResources>
+ <jarResource>
+ <groupId>org.codehaus.mojo.webstart.it006</groupId>
+ <artifactId>sign-one</artifactId>
+ <version>1.0</version>
+ <mainClass>org.mycompany.webstart.HelloWorld</mainClass>
+ </jarResource>
+ </jarResources>
+ </jnlpFile>
+ </jnlpFiles>
+
+ <sign>
+ <keystore>${project.build.directory}/keyStore</keystore> <!-- path or URI (if empty, the default keystore ".keystore"-file in the user-homedir is used) -->
+ <keypass>password</keypass> <!-- we need to override passwords easily from the command line. ${keypass} -->
+ <storepass>password</storepass> <!-- ${storepass} -->
+ <alias>webstart</alias> <!-- alias of the key to use -->
+ <!-- the following key-settings are only used if the keystore and key has to be generated at build-time -->
+ <storetype>jks</storetype>
+ <validity>365</validity>
+ <dnameCn>Firstname Lastname</dnameCn>
+ <dnameOu>OrganisationalUnit</dnameOu>
+ <dnameO>Organisation</dnameO>
+ <dnameL>Location</dnameL>
+ <dnameSt>State</dnameSt>
+ <dnameC>CountryCode</dnameC>
+
+ <!-- KEYSTORE MANGEMENT -->
+ <keystoreConfig>
+ <delete>true</delete> <!-- delete the keystore at build time -->
+ <gen>true</gen> <!-- generate keystore and key at build time -->
+ </keystoreConfig>
+
+ <verify>false</verify> <!-- verify the signature after signing -->
+ </sign>
+ <unsign>true</unsign> <!-- unsign already signed packages and sign them with own key -->
+
+ <verifyjar>false</verifyjar>
+ </configuration>
+ </plugin>
+ </plugins>
+
+ <finalName>webapp</finalName>
+ </build>
+</project>
Index: plugin/src/it/it006/validate.groovy
===================================================================
--- plugin/src/it/it006/validate.groovy (revision 0)
+++ plugin/src/it/it006/validate.groovy (revision 5940)
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+def assertExistsDirectory( file )
+{
+ if ( !file.exists() || ! file.isDirectory() )
+ {
+ println( file.getAbsolutePath() + " file is missing or is not a directory." )
+ return false
+ }
+ return true
+}
+
+def assertExistsFile( file )
+{
+ if ( !file.exists() || file.isDirectory() )
+ {
+ println( file.getAbsolutePath() + " file is missing or a directory." )
+ return false
+ }
+ return true
+}
+
+File target = new File( basedir, "webstart/target" )
+assert assertExistsDirectory( target )
+
+String[] expectedFiles = [ "webapp.war" ]
+expectedFiles.each{
+ assert assertExistsFile( new File ( target, it ) )
+}
+
+File explodedWebstart = new File( target, "webapp/webstart" )
+assert assertExistsDirectory( explodedWebstart )
+
+String[] expectedJnlpFiles = [ "sign-one-1.0.jar", "launch1.jnlp", "version.xml" ]
+expectedJnlpFiles.each{
+ assert assertExistsFile( new File ( explodedWebstart, it ) )
+}
+
+assert explodedWebstart.list().length == expectedJnlpFiles.length
+
+return true
Index: plugin/src/it/it002/webapp/pom.xml
===================================================================
--- plugin/src/it/it002/webapp/pom.xml (revision 5937)
+++ plugin/src/it/it002/webapp/pom.xml (revision 5940)
@@ -45,11 +45,6 @@
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>webstart-maven-plugin</artifactId>
- <!--
- Due to incomplete alpha-status a patched snapshot version is used.
- * maven-webstart-plugin (revision 5700
- + patch http://jira.codehaus.org/browse/MWEBSTART-63 "MWEBSTART-63-patch.diff")
- -->
<version>testing</version>
<executions>
<execution>
Index: plugin/pom.xml
===================================================================
--- plugin/pom.xml (revision 5937)
+++ plugin/pom.xml (revision 5940)
@@ -126,7 +126,7 @@
<dependency>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
- <version>2.2-20071211.162432-6</version>
+ <version>2.2</version>
</dependency>
<dependency>
<groupId>org.codehaus.mojo</groupId>
---------------------------------------------------------------------
To unsubscribe from this list please visit:
http://xircles.codehaus.org/manage_email
