Well, consider what happens even without the tomcat-maven-plugin. If you use the maven-war-plugin overlay feature, you can easily end up with multiple dueling versions of struts in your WEB-INF/lib, unless you carefully write 'excludes'. I'm just proposing that the plugin should come up with the same answer, but I'm not sure that I know how to arrange that.
On Thu, May 5, 2011 at 8:43 AM, Olivier Lamy <[email protected]> wrote: > Hello, > Sounds nice feature (fun as I'm figthing now with that and some extra > maven xml lines too to enable this :-) ). > > I wonder how do you see adding those dependencies coming from *overlays* jars. > > Simple use case : > - your project has a dependency on struts 2.1 > - war overlay has dependency on struts 2.0 > > > Simply adding WEB-INF/lib/*.jar looks dangerous for me as both struts > version will be probably in the classpath > > /Olivier > > 2011/5/5 Benson Margulies <[email protected]>: >> I only dealt with the 'meanwhile'. The first question here is still alive: >> >> If an *overlay* has jars in its WEB-INF/lib that are not listed as pom >> dependencies, should the plugin be trying to at least get them into >> the runtime classpath? >> >> If 'yes', I'll open a JIRA and perhaps try to do something about it. >> If 'no', no. >> >> On Thu, May 5, 2011 at 4:22 AM, Olivier Lamy <[email protected]> wrote: >>> Hello, >>> Looks you fix the doc ;-) >>> Is there something else which break ? or you're fine ? >>> >>> -- >>> Olivier Lamy >>> http://twitter.com/olamy >>> http://www.linkedin.com/in/olamy >>> >>> 2011/5/4 Benson Margulies <[email protected]>: >>>> I've now got a webapp that uses the maven-war-plugin overlay >>>> mechanism. It runs fine with :run-war, but not with :run. >>>> >>>> I think I know why, and I don't know if it's reasonable to make it work. >>>> >>>> The overlay dependency has, itself, no dependencies. I took not-maven >>>> war file and pushed it into my repo with type=war. It works fine as an >>>> overlay; all of its WEB-INF/lib ends up in the eventual WEB-INF/lib. >>>> But it's not surprising that it's opaque to the 'dynamic' classpath. >>>> >>>> Should I nonetheless submit a JIRA? The tomcat plugin could, in >>>> theory, organize WEB-INF/lib/*.jar into the classpath. >>>> >>>> Meanwhile, does addContextWarDependencies know enough to skip >>>> overlays? It doesn't make sense to launch a 'dependency of type war' >>>> as a separate webapp if it is an overlay? >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe from this list, please visit: >>>> >>>> http://xircles.codehaus.org/manage_email >>>> >>>> >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe from this list, please visit: >>> >>> http://xircles.codehaus.org/manage_email >>> >>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe from this list, please visit: >> >> http://xircles.codehaus.org/manage_email >> >> >> > > > > -- > Olivier Lamy > http://twitter.com/olamy > http://www.linkedin.com/in/olamy > > --------------------------------------------------------------------- > To unsubscribe from this list, please visit: > > http://xircles.codehaus.org/manage_email > > > --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
