Hi Tony,

To explain my rationale for making the license.txt file name and location be configurable is that in my project the name and location of the file is not within my project or under my control. This makes it necessary to make a copy in my project and keeping that copy aligned. The problem would go away if there was a simply way to configure the location and name of this file in plugin config.

Do you find this a reasonable rationale? If so, I will file an RFE and would be willing to help you with developing and testing of a patch to address the issue.

Please advice what you think on for both ideas:

   * Allow license file path to be configurable in plugin config
   * Remove license resolver and license.properties and allow both
     header and license files to be configurable in plugin config

Thanks very much.


On 08/24/2011 08:27 AM, Farrukh Najmi wrote:

Hi Tony,

Thank you for taking the time to provide this very simple solution to my problem. This is a terrific plugin and I highly recommend it to others.

One minor suggestion I have is that the plugin config or license.properties should allow overriding the license file name so its not hardcoded to license.txt. Then we would not have to name a license.html file as license.txt which creates problems and confusion.

A variation on above suggestion that is more change is to consider simplifying the design by making both header and license file locations to be configured directly in plugin configuration and remove the license resolver and license.properties file altogether. Based on my admittedly limited experience with the plugin, I am not seeing the benefit of the more complex approach with license resolver, license.properties file and hardcoded license and header file names.

If you think it is a reasonable request then I can file an RFE. Again thanks very much for your help and for a terrific plugin.

--
Regards,
Farrukh Najmi

Web: http://www.wellfleetsoftware.com


Reply via email to