Create a JIRA issue here: http://issues.apache.org/jira/browse/OFBIZ
you will need to quickly register --- Jonathon -- Improov <[EMAIL PROTECTED]> wrote: > Jacques, > > Oh, ok. But it's a 1-second change. Anyway, patch is > attached. > > Is this the right place/way to discuss suggested > changes to OFBiz? Is there a place where I should > put all my change requests? > > Jonathon > > Jacques Le Roux wrote: > > Jonathon, > > > > May you want to create a patch for this ? > > > > Jacques > > > > ----- Original Message ----- > > From: "Brent Smithson" <[EMAIL PROTECTED]> > > To: <[email protected]> > > Sent: Friday, January 12, 2007 10:30 PM > > Subject: RE: Suggested change to > ProductFeatureServices.getVariantCombinations() > > > > > >> I agree, it is our practice as well to add the > '-'. > >> > >> - Brent > >> > >> -----Original Message----- > >> From: Jacques Le Roux > [mailto:[EMAIL PROTECTED] > >> Sent: Friday, January 12, 2007 12:06 PM > >> To: [email protected] > >> Subject: Re: Suggested change to > >> ProductFeatureServices.getVariantCombinations() > >> > >> Yes, sounds lilke a good idea indeed > >> > >> Jacques > >> > >> ----- Original Message ----- > >> From: "Scott Gray" <[EMAIL PROTECTED]> > >> To: <[email protected]> > >> Sent: Friday, January 12, 2007 8:22 PM > >> Subject: Re: Suggested change to > >> ProductFeatureServices.getVariantCombinations() > >> > >> > >>> Hi Jonathan > >>> > >>> I have done the same thing, I would say if any > objected it could > >> always > >>> be added to one of the property files. > Something like > >>> product.variant.id.feature.separator=- > >>> > >>> Jonathon -- Improov wrote: > >>>> Currently, that function appends the > ProductFeature idCode(s) > >>>> immediately to the end of the Product ID. So, > WG-9943 will have > >>>> WG-9943B3 rather than WG-9943-B3. > >>>> > >>>> Can I just add a '-' before the entire string > of ProductFeature > >>>> idCode(s)? Or should I do more work to store > this prefix '-' in some > >>>> entity linked to a Product? > >>>> > >>>> I'd like to have this feature rolled into > OFBiz. Thanks! > >>>> > >>>> Jonathon > >>>> > > > > > > > Index: ProductFeatureServices.java > =================================================================== > --- ProductFeatureServices.java (revision 494312) > +++ ProductFeatureServices.java (working copy) > @@ -227,7 +227,7 @@ > List newFeatures = > new LinkedList(); > List newFeatureIds = > new LinkedList(); > if > (currentFeature.getString("idCode") != null) > - > newCombination.put("defaultVariantProductId", > productId + currentFeature.getString("idCode")); > + > newCombination.put("defaultVariantProductId", > productId + "-" + > currentFeature.getString("idCode")); > else > > newCombination.put("defaultVariantProductId", > productId); > > newFeatures.add(currentFeature); >
