David,
> Hopefully what I wrote clears this up a bit. Again, the documents on
> www.apache.org/dev clarify a lot of these issues.
Clear.
> it is ultimately the responsibility of the PMC to take care of this, and that
> responsibility is delegated to non-PMC committers (though PMC members should
> still review commits and issues to check on this).
True. I'd say the "ease/rate of integration of contribution into OFBiz" depends on
motivation/impetus. If I wanted my contributions merged in fast, I'd do my part to aid the PMC in
their responsibility to keep the source clean.
Somebody (don't know who) mentioned "sabotage via contribution of unclean codes". I guess that
means it's dangerous to "shake hands with just about any external contributor, and commit
contributions based on good faith alone".
Jonathon
David E. Jones wrote:
On Jan 28, 2007, at 11:46 PM, Jacques Le Roux wrote:
Jonathon,
Just one word to be sure you understand your responsability by opening
your "sandbox" to other users without contracts between you
(hence creating a joint work as pointed out by Chris). You will have
to get through this procedure
http://incubator.apache.org/ip-clearance/index.html
Not necessarily. It is up to the committers to review this, but the
general guideline is to distinguish (as explained on that page and in
related documents) based on how and why it was developed.
For example, if someone fixes a bug in OFBiz in almost any case if it is
contributed back then the how and why is pretty clear. The amount of
time that lapses between doing it an contributing it doesn't really matter.
If you don't and don't tell us (commiters) you will be the sole
responsable because of our good faith (not knowing that it comes not
only from you).
This is a dangerous idea Jacques. It is the responsibility of all
committers to make sure the source of the code is clear, especially
where it may have been developed independently and not intended to go
into OFBiz but someone else took it and contributed it. Under no
circumstances is it okay for that code to go into OFBiz, and it is
ultimately the responsibility of the PMC to take care of this, and that
responsibility is delegated to non-PMC committers (though PMC members
should still review commits and issues to check on this).
This is only my opininon and not commiters's or PMC's or even ASF's,
of course.
Hopefully what I wrote clears this up a bit. Again, the documents on
www.apache.org/dev clarify a lot of these issues.
-David