Well, it turns out it's not fixed in the latest. While it does make it
further into the code, it gets skipped over because of line 894:
while (itemByOrderIt.hasNext()) {-----Original Message----- From: Sanders, Brian [mailto:bsand...@connextions.com] Sent: Wednesday, April 15, 2009 8:40 AM To: user@ofbiz.apache.org Subject: RE: Refunding adjustments only Ok, I was looking at the head for 4.0. It appears that the issue is fixed in the latest. Thanks. -----Original Message----- From: Jacques Le Roux [mailto:jacques.le.r...@les7arts.com] Sent: Tuesday, April 14, 2009 4:15 PM To: user@ofbiz.apache.org Subject: Re: Refunding adjustments only Are you speaking about the last release available at the moment (r764940) ? I don't see nay TODO on line 801 and moreover this is not a line of OrderReturnServices.processRefundReturn() method. The last change in this file was commited by me in r763175 one week ago http://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/order/src/ org/ofbiz/order/order/OrderReturnServices.java?r=763175 Could you clarify please ? Jacques From: "Sanders, Brian" <bsand...@connextions.com> > It's in the head revision as well on line 801. > > -----Original Message----- > From: Sanders, Brian [mailto:bsand...@connextions.com] > Sent: Tuesday, April 14, 2009 12:32 PM > To: user@ofbiz.apache.org > Subject: RE: Refunding adjustments only > > When the project was imported into our repo, the revision # was 684368. > The TODO was there. > > -----Original Message----- > From: Jacques Le Roux [mailto:jacques.le.r...@les7arts.com] > Sent: Tuesday, April 14, 2009 12:01 PM > To: user@ofbiz.apache.org > Subject: Re: Refunding adjustments only > > I did not find any TODO in OrderReturnServices.processRefundReturn() > Are you sure its plain OFBiz code ? > If yes, which Release.revision are you using ? > > Jacques > > From: "Sanders, Brian" <bsand...@connextions.com> > If you look at processRefundReturn, you will notice that none of the > code runs unless there is at least 1 line item. If you are refunding > only, say, freight charges, the refund will not actually occur. There is > a TODO labeled "add adjustment total" which sounds like the developers > are aware of the issue. Is there a reason that it has not been > implemented yet? If I were to try and implement the functionality > myself, is there anything I should be aware off? Can anyone offer some > tips/suggestions as to how to implement? Thanks. > > > >
