Hi Scott - in line Cheers Sam
On 30/06/2010 13:57, Scott Gray wrote: > On 30/06/2010, at 4:57 PM, Sam Hamilton wrote: > >> Hi Guys, >> >> I am trying to widen my knowledge of OFBiz and so I started looked >> though the jar files that we import from other projects. >> >> There are a number which are not running the latest version e.g. >> - lucene is 2.4.1 but latest stable is 3.0.2 even going back to the 2 >> branch the latest is 2.9.3 >> - ant is 1.7.1 but latest stable is 1.8.1 >> - freemarker is 2.3.15 but latest stable is 2.3.16 >> - log4j is 1.2.15 but latest stable is 1.2.16 >> the list goes on but I am sure you see what I mean. >> >> For me keeping these up to date would mean that people would get less >> errors when using OFBiz but my question is what would be the right way >> to help get these upgraded? >> >> I think it would go: >> 1. check mailing list if someone has tried to upgrade already and had >> problems; if so ignore. >> 2. locally upgrade >> 3. run ant tests >> 4. test the function that these jar files do locally >> 5. jira issue >> 6. upload patch >> 7. wait for a committer to add into the project. >> 8. rinse and repeat > > Sounds pretty accurate. Ideally instead of ignoring #1 we'd try and solve > the issue or at least create a jira to track it. > >> For ones like freemarker how do you know its working correctly? > > For minor release upgrades we shouldn't have too many problems since they're > typically just bug fixes but if we can still render a template after trying a > few of them out then we should be in good shape. > >> What would you be looking for if the ant tests worked etc? > > Not entirely sure what you mean. The ant tests only hit a very small portion > of the codebase so the odds of getting a false positive are pretty high. I meant what else would you check next if 1. ant tests worked 2. logs looked ok and 3. user function test the changed file. Or does that cover almost all possible ways to find the error. > >> I would check in >> the log files for any error messages when using the system as a user but >> beyond that what else can you check? > > You're really just testing #4, try and figure out where the jar is used and > that it still functions as expected. > > Regards > Scott
