I tried it and it worked fine for me. It flunked the first time because I was short one of the nulls.
Skip -----Original Message----- From: deepak.agar...@paxcel.net [mailto:deepak.agar...@paxcel.net]On Behalf Of Deepak Agarwal Sent: Friday, May 31, 2013 3:59 AM To: user@ofbiz.apache.org Subject: Re: But in CategoryTree.groovy I might have missed something but findList("EntityName", null, null, null, null, false) doesn't work for me from ftl because of 'null' . On Fri, May 31, 2013 at 1:13 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Last pragmatic cons note for findAll("EntityName"), > instead of findList("EntityName", null, null, null, null, false) > > It's much easier to remember when you have to use it in envs where there > is no auto-completer, like Groovy scripts in Eclipse. > > This would mean to revert r938947 and I guess some others commits, not > sure all will agree... > > If ever we agree on this. Are there other high level methods (like > findAll("EntityName"), ie w/o parameters just EntityName) we would > reintroduce? > > Jacques > > Jacques Le Roux wrote: > > About findAll(), yes it's a moot point > > > > David got into this direction 5 years ago and nobody was really against > it > > http://markmail.org/message/thcsl7khketkqagh > > > > One of the ideas was to get rif of all the variations and use rather > parameters, take for instance > > http://svn.apache.org/viewvc?view=revision&revision=938948 > > > > IMO, Jonathan had a good point about owen buttons in the thread above > > One thing we would consider is reintroducing most simplifed ones, like > findAll(), yes! > > > > But maybe Scott would be agains it > > http://svn.apache.org/viewvc?view=revision&revision=938947 > > > > Opinions? > > > > Jacques > > > > From: "Skip" <s...@thedevers.org> > >> Jacques > >> > >> That works fine. findAll() works for me because I added it back in. > >> findAll() is a better function to use because in my opinion, it sez > exactly > >> what it does and that makes the code more readable. I have hundreds of > java > >> files written over the years and it was way easier to add back in the > >> functionality you guys deprecated/removed than to replace all my entity > >> engine calls. > >> > >> This time however, I put them all together so it would be easier next > time > >> you guys do a major release. > >> > >> BTW, I have had a few weeks now to go pretty thoroughly through lots of > this > >> code and it is very nice. I am especially pleased with the re-write of > the > >> widget code and the use of jquery. > >> > >> Skip > >> > >> -----Original Message----- > >> From: Jacques Le Roux [mailto:jacques.le.r...@les7arts.com] > >> Sent: Thursday, May 30, 2013 6:38 AM > >> To: user@ofbiz.apache.org > >> Subject: Re: But in CategoryTree.groovy > >> > >> > >> Thanks for report Skip, > >> > >> BTW you must have missed something, findAll does not exist anymore for 3 > >> years ;) > >> http://svn.apache.org/viewvc?view=revision&revision=938947 > >> > >> Using > >> prodCatalogs = delegator.findList("ProdCatalog", null, null, null, null, > >> false); > >> Should be the way. Could you please confirm before I commit? > >> > >> Thanks > >> > >> Jacques > >> > >> From: "Skip" <s...@thedevers.org> > >>> There is a line at 50 that sez: > >>> > >>> prodCatalogs = delegator.findByAnd("ProdCatalog"); > >>> > >>> This causes a groovy ambiguious error when you go to the catalog > screen in > >>> 12.04. > >>> > >>> Changing this to: > >>> prodCatalogs = delegator.findAll("ProdCatalog"); > >>> > >>> Fixes the problem. > >>> > >>> I expect you guys already did this, there here it is for any others > like > >> me > >>> that just download the zip file. > >>> > >>> Skip > -- Thanks, Deepak Agarwal, Mobile: +91 9501190044
