I had been thinking along the lines of #2, but #1 seems quite user friendly
to me.  Although if there is an immediate flag for endEdit() then users
might expect beginEdit() to have one also.

I think I might have misunderstood your reasoning about #1?  If my logic
determines that there should be no transition when the editor is closed, and
I choose to set the immediate flag on endEdit(), then I shouldn't be
surprised when no transition occurs! :)

Chris

On 1 December 2010 20:38, Greg Brown <[email protected]> wrote:

> I can think of two possible solutions to the editor transition issue:
>
> 1) Provide a boolean "immediate" flag to endEdit(). If true, the editor
> should not run any transitions but should instead close immediately.
>
> 2) Provide a listener argument to endEdit() that will be called when the
> transition is complete (e.g.
> TableView.RowEditorListener#editComplete(boolean)).
>
> I prefer #2, since #1 would preclude running any kind of transition in
> these cases.
>
> Thoughts?
>
> G
>
>

Reply via email to