> Basically, it removes redundant imports, but it also "compresses", if you > have more than X imports for the same package, it will remove all those and > import package.* instead.
We don't use wildcard imports in the Pivot codebase since it tends to obscure the classes that are actually being used (makes it harder to understand what is going on if you are not familiar with the code). Also, my understanding is that there is minimal performance benefit to import *. >>> I guess the patch should touch as little as possible when it doesn't have >>> to do with the actual functionality right? >> Yes, minimizing the surface area of a patch is always good since it makes it >> easier to see the non-trivial changes. > OK, I understand. Here is my patch, without the IDEA wizardry :) Should I > create an issue and refer to the usecase in this thread? Yes, patches should always be submitted via JIRA. > PS: As you know, I have no deep knowledge of Pivot yet, but this seemed very > clear cut. I might have missed something though... I basically added the > methods, made sure Window#open calls the listeners and if voted down, > respects the Veto and notifies listeners about the veto. I added default > implementations to the Adapter and let implementations use the Adapter where > appropriate. I'll take a look.
