The patch was applied in r1044370.
Please try the latest build from trunk. Daily builds can be downloaded
from here:
http://encore.torchbox.com/poi-cvs-build/
Regards,
Yegor
On 12/9/2010 8:34 AM, Marcel May wrote:
Thx Jon and David.
I added the patch fixing NPV to the ticket.
Jon, let me know if the patch does not work.
There's a simple JUnit test case included, too.
Cheers,
Marcel
On Dec 9, 2010, at 8:28 AM, Jon Svede wrote:
I created issue #50437 and attached my .xls file. Marcel can work from that and
submit his test case or I can create one.
Jon
----- Original Message ----
From: Jon Svede<jsv...@yahoo.com>
To: POI Users List<user@poi.apache.org>
Sent: Wed, December 8, 2010 9:10:40 PM
Subject: Re: NPV bug?
Hi all,
Sorry for the delay in responding.
I can create the ticket and the test case, I'll try to get to this by the end
of the week.
Thanks for the confirmation!
Jon
----- Original Message ----
From: David Fisher<dfis...@jmlafferty.com>
To: POI Users List<user@poi.apache.org>
Sent: Wed, December 8, 2010 5:42:15 PM
Subject: Re: NPV bug?
Hi Marcel,
Please have a look at http://poi.apache.org/guidelines.html in the "Submitting
Patches" section.
Thanks and Regards,
Dave
On Dec 8, 2010, at 2:46 PM, Marcel May wrote:
<npv.patch.txt>
Oops, the patch got swallowed.
On Dec 9, 2010, at 2:33 AM, Marcel May wrote:
I can confirm this is a bug - just had the same problem.
a) the NPV computation is wrong
- sum += ds[i] / Math.pow(rate + 1, i);
+ sum += ds[i] / Math.pow(rate + 1, i+1);
I think the computation should actually use the FinanceLib#npv method (which
is correct).
b) The impl does not support ranges
I got a patch fix a) and b), including a test case:
Jon, do you want to create the bug ticket? Then I'll add my patch for it.
Cheers,
Marcel
...
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscr...@poi.apache.org
For additional commands, e-mail: user-h...@poi.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscr...@poi.apache.org
For additional commands, e-mail: user-h...@poi.apache.org
