The reason is that I have, in special cases, to change the name of the dialog name to start and I can't change the code of my web application. For example: public ... create(javax.faces.context.FacesContext context, String name) { if(usaPresident.equalsIgnoreCase("BUSH")) name = "NoWarsPlease";
super.create(context,name); } (I don't understand the antipattern..... and I don't understand why org.apache.shale.dialog.basic.BasicDialogManager is final) Thanks Mario -----Original Message----- From: Rahul Akolkar [mailto:[EMAIL PROTECTED] Sent: 23 luglio 2007 21.19 To: user@shale.apache.org Subject: Re: Customizing Basic DialogContextManager On 7/20/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Hi Rahul, > What I need is to extend the "create" method of > org.apache.shale.dialog.basic.BasicDialogManager > > for example doing: > > public ... create(javax.faces.context.FacesContext context, > String name) > { > Super.create(context,name); > System.out.println("Hello Rahul"); > } > <snip/> I'm saying this is more an anti-pattern (i.e. avoid, if possible :-) Can you use the DialogContextManagerListener [1] for this purpose? If not, I'll go back to my questions two replies ago -- what is the reason? Is the reason related to SHALE-454 [2] ? -Rahul [1] http://shale.apache.org/shale-dialog/apidocs/org/apache/shale/dialog/Dia logContextManagerListener.html [2] http://issues.apache.org/struts/browse/SHALE-454 > > Thanks > Mario > > -----Original Message----- > From: Rahul Akolkar [mailto:[EMAIL PROTECTED] > Sent: 19 luglio 2007 22.37 > To: user@shale.apache.org > Subject: Re: Customizing Basic DialogContextManager > > On 7/17/07, [EMAIL PROTECTED] > <[EMAIL PROTECTED]> wrote: > > No response? Every body to the beach? :) > > > <snip/> > > For me to say anything else here, I'd need a bit more about what you > are trying to do (rather than the how, which you've detailed below) > and what the basic implementation is hindering you from doing. > > -Rahul > > > > > Ciao > > Mario > > > > -----Original Message----- > > From: Rahul Akolkar [mailto:[EMAIL PROTECTED] > > Sent: 11 luglio 2007 18.20 > > To: user@shale.apache.org > > Subject: Re: Customizing Basic DialogContextManager > > > > On 7/10/07, [EMAIL PROTECTED] > > <[EMAIL PROTECTED]> wrote: > > > I feel boycotted :) > > > May be the problem is my email address? > > > > > <snip/> > > > > No. Sometimes (or, often, it depends on many factors) it can take a > > couple of days to get a response. Please be patient. > > > > > > > -----Original Message----- > > > From: [EMAIL PROTECTED] > > > [mailto:[EMAIL PROTECTED] > > > Sent: 9 luglio 2007 11.25 > > > To: user@shale.apache.org > > > Subject: RE: Customizing Basic DialogContextManager > > > > > > Another way I have tested is to extends directly > > > AbstractDialogContextManager overriding all public methods using the > > > wrapped > > > org.apache.shale.dialog.basic.BasicDialogManager. > > > > > > Is this solution better then the first? > > > > > <snap/> > > > > Generally, I'd discourage folks from customizing any of the dialog > > impls provided for a couple of reasons (though I'd encourage them to > > write brand new impls): > > > > * Any custom impl means that you are no longer using the basic impl > > as we all know it (some bets are off, its harder for anyone on this > > list to help without reasonable background each time etc.). > > > > * It should be possible to get a lot of things done leveraging some > > of the features of the dialog framework (such as the various > > listeners) before getting into customization. Also, if there are > > things missing or value-adds to the dialog framework, then IMO its > > better to push for those bits to be included in the API or impls > > itself (as the case may be). Perhaps you have done this design > > exercise already. > > > > I won't claim to have completely understood what the end goal is for > > this particular customization. Is this in any way related to: > > > > http://issues.apache.org/struts/browse/SHALE-454 > > > > that you filed recently? > > > > -Rahul > > > > > > > > > Regards > > > Mario > > > > > > P.S. could be easier if > > org.apache.shale.dialog.basic.BasicDialogManager > > > is not final! > > > <snap/> This message is for the designated recipient only and may contain privileged, proprietary, or otherwise private information. If you have received it in error, please notify the sender immediately and delete the original. Any other use of the email by you is prohibited.