Good catch on the notice and the release notes! I think we should respin the release because of this, these files are included in the source-zip (even though the last release missed them) Sorry Francois, I know you have already done this twice,I can volunteer to help next week when I'm back at my desk.
On Thu, Mar 10, 2022 at 1:57 AM Colm O hEigeartaigh <[email protected]> wrote: > +1. However the NOTICE year was out of date, and the release notes > don't appear to have been updated in a while. I pushed a fix for the > NOTICE year. > > Colm. > > On Wed, Mar 9, 2022 at 10:04 AM Jean-Baptiste Onofré <[email protected]> > wrote: > > > > Thanks. If the most important thing is to have dist updated at the end of > > the day, I think it's interesting to give a chance to review the source > > artifact on a staging dist (dev), just to double check what we official > > publish ;) > > > > Anyway, here's my +1 (binding) > > > > Thanks again ! > > > > Regards > > JB > > > > On Wed, Mar 9, 2022 at 9:40 AM Francois Papon < > [email protected]> > > wrote: > > > > > Hi, > > > > > > The sources has been pushed to dist dev: > > > > > > https://dist.apache.org/repos/dist/dev/shiro/1.9.0/ > > > > > > I will update the release process wiki page. > > > > > > regards, > > > > > > François > > > > > > On 09/03/2022 09:16, Francois Papon wrote: > > > > Hi JB, > > > > > > > > We never pushed sources to the dev dist and it may be a missing step > > > > in the process: > > > > > > > > > https://cwiki.apache.org/confluence/display/SHIRO/Performing+a+Release > > > > > > > > We only push to the dist prod but we can add a step to push on dev. > > > > > > > > regards, > > > > > > > > On 09/03/2022 05:47, Jean-Baptiste Onofré wrote: > > > >> I checked and I don’t see the staged artifact on > > > >> dist.apache.org/dist/dev/shiro. > > > >> > > > >> As reminder it’s required to have source artifact on > dist.apache.org. > > > >> > > > >> It’s the same as maven repository but dist is mandatory from Apache > > > >> standpoint (common to any project even the ones not using maven). > > > >> > > > >> Can you please upload source artifact to dist ? > > > >> > > > >> Thanks > > > >> Regards > > > >> JB > > > >> > > > >> Le mar. 8 mars 2022 à 22:47, Francois Papon > > > >> <[email protected]> > > > >> a écrit : > > > >> > > > >>> This is a call to vote in favor of releasing Apache Shiro version > > > >>> 1.9.0. > > > >>> > > > >>> We solved 20 issues for 1.9.0: > > > >>> > > > >>> > > > >>> > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310950&version=12350639 > > > >>> > > > >>> > > > >>> > > > >>> Bug > > > >>> > > > >>> [SHIRO-829] - beanPostProcessor and FactoryBean cause aop to > fail > > > >>> in the same Configuration > > > >>> [SHIRO-845] - Dependencies for test-jars missing > > > >>> > > > >>> Improvement > > > >>> > > > >>> [SHIRO-804] - Avoid conflicts with spring boot aop > > > >>> [SHIRO-836] - Delete jsecurty-sample.jks > > > >>> [SHIRO-838] - Create SHA512-Hashes > > > >>> [SHIRO-846] - Creation of site takes very long time > > > >>> [SHIRO-848] - Relative Path in pom.xml is not needed > > > >>> [SHIRO-850] - The profile name jdk19-plus is misleading > > > >>> [SHIRO-851] - Handling properties for compile/enconding vs. > > > >>> default > > > >>> configurations of plugins > > > >>> [SHIRO-852] - Configuration for maven-release-plugin > > > >>> prepationGoal > > > >>> should be changed > > > >>> [SHIRO-853] - Versions of maven-surefire/failsafe/report > > > >>> plugin are > > > >>> not in sync > > > >>> [SHIRO-854] - Konfiguration includes/excludes > > > >>> maven-failsafe-plugin > > > >>> can be reduced to default > > > >>> [SHIRO-860] - update logback to 1.2.10 > > > >>> [SHIRO-862] - Replace Google Analytics with Matomo for new > > > >>> Javadocs > > > >>> > > > >>> Task > > > >>> > > > >>> [SHIRO-841] - NullPointerException from > > > >>> SessionsSecurityManager.start() > > > >>> [SHIRO-867] - Skip Deployment of integration-test and samples > > > >>> artifacts > > > >>> > > > >>> Dependency upgrade > > > >>> > > > >>> [SHIRO-828] - aspectj-maven-plugin 1.14.0 > > > >>> [SHIRO-842] - shiro-web depends on older log4j > > > >>> [SHIRO-843] - Update maven-project-info-reports > > > >>> [SHIRO-844] - Update maven-javadoc-plugin to 3.3.1 > > > >>> > > > >>> Staging repo: > > > >>> > https://repository.apache.org/content/repositories/orgapacheshiro-1039 > > > >>> > > > >>> > > > >>> > > > > https://repository.apache.org/content/repositories/orgapacheshiro-1039/org/apache/shiro/shiro-root/1.9.0/shiro-root-1.9.0-source-release.zip > > > >>> > > > >>> < > > > >>> > > > > https://repository.apache.org/content/repositories/orgapacheshiro-1039/org/apache/shiro/shiro-root/1.9.0/shiro-root-1.9.0-source-release.zip > > > >>> > > > >>> Source release checksum(s): > > > >>> shiro-root-1.9.0-source-release.zip sha512: > > > >>> > > > >>> > > > > 2ca1fee41fbed1ab28077a4ff785b8a372913fd78eafe69fd5ee118328234c87c7a0b14cf2dbcba59b79ac286f108998fb0ea15e21af54df79eb8967cc12a32d > > > > > > >>> > > > >>> > > > >>> Project website (just for informational purposes, not to be voted > > > >>> upon): > > > >>> http://shiro.apache.org/ > > > >>> > > > >>> Guide to testing staged releases: > > > >>> > http://maven.apache.org/guides/development/guide-testing-releases.html > > > >>> > > > >>> Vote open for 72 hours. Please examine the source and binaries > before > > > >>> voting. > > > >>> > > > >>> [ ] +1 > > > >>> [ ] +0 > > > >>> [ ] -1 (please include reasoning) > > > >>> > > > >>> > > > >
