The public API of MLlib is meant to be Java-friendly, so that's why it has 
setters and getters with Java-like names. Internal APIs don't have to be.

Matei

On August 11, 2014 at 12:08:20 PM, Koert Kuipers (ko...@tresata.com) wrote:

i was just looking at ALS 
(mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala)....

any need all the variables need to be vars and to have all these setters 
around? it just leads to so much clutter

if you really want them to the vars it is safe in scala to make them public 
(scala creates setters and getters anyhow for you, so you can change a var to 
methods later if you want other variables, without breaking APIs).

but a more scala-friendly style would be vals and no setters...

best, koert
  • mllib style Koert Kuipers
    • Re: mllib style Matei Zaharia

Reply via email to