On 20/10/25 11:04, Feder, Stephan wrote:
Hello, Francesco,

Thank you for responding.

On Mon, Oct 20, 2025 at 08:51:07AM +0200, Francesco Chicchiriccò wrote:
...
On 17/10/25 17:13, Feder, Stephan wrote:
...
public Pair<UserUR, List<PropagationStatus>> update(
    final UserUR userUR,
    final boolean nullPriorityAsync,
    final String updater,
    final String context
)

is not annotated with

@Transactional(propagation = Propagation.REQUIRES_NEW)

although the corresponding methods in DefaultGroupProvisioningManager and 
DefaultAnyObjectGroupProvisioningManager are. Is this intentional or an 
oversight?
...
if you look carefully, the update() method annotated with @Transactional [1] is not the same as defined by DefaultGroupProvisioningManager or DefaultAnyObjectGroupProvisioningManager since it is an implementation of [2].

Sorry for the confusion, I pasted the wrong method. The method I meant is

public Pair<UserUR, List<PropagationStatus>> update(
    final UserUR userUR,
    final Set<String> excludedResources,
    final boolean nullPriorityAsync,
    final String updater,
    final String context
)

I see, but the reason is what reported above, only the update() methods being 
called during Pull Task execution needs to be annotated in order to work 
properly; hence:

* Users: [1] is called by [2]
* Groups: [3] is called by [4]
* Any Objects: [5] is called by [6]

Hope this clarifies.
Regards.

[1] 
https://github.com/apache/syncope/blob/master/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/DefaultUserProvisioningManager.java#L147
[2] 
https://github.com/apache/syncope/blob/master/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultUserPullResultHandler.java#L127
[3] 
https://github.com/apache/syncope/blob/master/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/DefaultGroupProvisioningManager.java#L119
[4] 
https://github.com/apache/syncope/blob/master/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultGroupPullResultHandler.java#L113
[5] 
https://github.com/apache/syncope/blob/master/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/DefaultAnyObjectProvisioningManager.java#L100
[6] 
https://github.com/apache/syncope/blob/master/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultAnyObjectPullResultHandler.java#L102

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA
https://about.me/ilgrosso

Reply via email to