Hi all,
I made change to an existing .thrift file, by adding a new struct:
struct NewRequest {
1: required list<i64> txn_ids,
}
After regenerating code, I do see the changes I want. But I also noticed there
are a bunch of files which are irrelevant to this change, but have many
variable names being changed, for example:
Previously:
org.apache.thrift.protocol.TMap _map524 = iprot.readMapBegin();
struct.metadata = new
HashMap<Long,MetadataPpdResult>(2*_map524.size);
long _key525;
MetadataPpdResult _val526;
for (int _i527 = 0; _i527 < _map524.size; ++_i527)
Now:
org.apache.thrift.protocol.TMap _map532 = iprot.readMapBegin();
struct.metadata = new
HashMap<Long,MetadataPpdResult>(2*_map532.size);
long _key533;
MetadataPpdResult _val534;
for (int _i535 = 0; _i535 < _map532.size; ++_i535)
I don't think this kind of change is harmful. But it requires code change for
irrelevant files, which is unexpected. Anyone knows the rationale behind this?
Thanks,
Wei