Hi, > I think the comma issue doesn't impact me since we are using binary > protocol and the json protocol was just for human readability.
Agree, but thanks anyway for spotting it. > By "not working" I mean when I try to login to the server it fails. All my > field values are correct, but I can only assume the server doesn't parse > things the same and fails. Any error messages maybe? Why do we have to always ask? > Is there a way for me to turn off this implicit rec and test? No, and you should not even try. It is part of the way how Thrift works. -----Ursprüngliche Nachricht----- From: C Bergström Sent: Tuesday, March 12, 2019 1:30 AM To: [email protected] Subject: Re: Python client vs C# client json/binary different.. a lot of extra comma!! (confused) On Tue, Mar 12, 2019 at 7:58 AM Jens Geyer <[email protected]> wrote: > > ok so maybe I should be asking where is the extra "1":{"rec": coming > from. > > Based on my auth_args.thrift I don't see why it should be generated. > > That is all fine. request and responses are implicitly wrapped into a > struct, that's where the "rec" comes from. It's not in the IDL, it is > added > implicitly by Thrift and yes, we need that. > > Why py does "not work" (still not clear what it means) - no idea. But the > JSON that comes out of C#/netcore/netstd is certainly wrong. I just > stepped > through the code and the commas seem indeed missing, if I did not overlook > anything. > I think the comma issue doesn't impact me since we are using binary protocol and the json protocol was just for human readability. By "not working" I mean when I try to login to the server it fails. All my field values are correct, but I can only assume the server doesn't parse things the same and fails. Is there a way for me to turn off this implicit rec and test? What tool can I used to decode the binary protocol version so I can look for differences there.
