negative ids could break stuff, such as here: https://github.com/apache/zookeeper/blob/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java#L321
On Mon, Jul 13, 2015 at 11:07 AM, Raúl Gutiérrez Segalés < [email protected]> wrote: > Hi, > > On 13 July 2015 at 10:43, Benjamin Anderson <[email protected]> wrote: > > > Hi there - I've observed that the documentation[1] suggests that each > > node's myid should be an integer in the range [1, 255]. Is that > > limitation codified anywhere? A quick perusal of the source suggests > > that myid is parsed in to a Long and passed around as such through the > > codebase. > > > > For context, I'm working on automating a ZK deployment and having a > > larger range for myid values would make my life easier. > > > > Yeah, definitely wrong (I've used 0, -1, ..). Mind opening a JIRA to get it > fixed (a patch would be > most welcomed too!). Otherwise I'll get to it a bit later. Thanks! > > > -rgs >
