Aaaaand, just like that, I have a working 3.4 patch! Sent you (and others) a PR, please take a look when you can!
On Mon, Jun 5, 2017 at 9:48 AM, Ben Sherman <[email protected]> wrote: > > >> > Finally, is there any way to shine any light on the above issues that >> > highlight this? I have considered forking 3.4.10 to do this, but the >> > overhead required is more than I can afford right now going down the >> line. > > >> I'm not sure I understand the question, why do you want to fork? > > > We want to getTCP keep-alives turned on as in: > > https://github.com/apache/zookeeper/pull/83 > and > https://issues.apache.org/jira/browse/ZOOKEEPER-1748 > > I am working on getting the nits fixed in the patch attached to that, but > I haven't sent a PR to ZK before, and I'd like to get this done quickly - > any assistance in getting this patched would be super helpful. That patch > got stalled long ago, and I'm worried the same might happen to mine. > > > > >
