Hey Enrico, If Mate can help to cut it - it would be great, if not - I'll need more detailed instructions on how to cut it please.
Thanks and Regards, Mike -----Original Message----- From: Enrico Olivelli [mailto:eolive...@gmail.com] Sent: Thursday, December 05, 2019 10:08 AM To: UserZooKeeper Subject: Re: java.lang.NullPointerException on some commands (stats, conf) Mike Il giorno gio 5 dic 2019 alle ore 15:55 Mike Smotritsky < mikesmotrit...@ongov.net> ha scritto: > Hey Mate, thank you very much for a very quick action on this issue. > If it's not very difficult can you please cut me a patched 3.5.6? > I think the best procedure is that you build your own patched version by yourself. Just "mvn clean install -DskipTests" on branch-3.5 Please be aware that the binaries you are going to use are not an official Apache release. I think it is fine, many companies run their own patched version of Open Source software Just my 2 cents Enrico > Again I very much appreciate your help! > > You guys have a very dedicated team on this project! > > Thanks and Regards, > Mike > > -----Original Message----- > From: Mate Szalay-Beko [mailto:msza...@cloudera.com.INVALID] > Sent: Thursday, December 05, 2019 3:48 AM > To: user@zookeeper.apache.org > Subject: Re: java.lang.NullPointerException on some commands (stats, conf) > > Hi Mike, > > 3.5.6 was already released a couple of weeks ago. Norbert cherry-picked the > NPE fix to branch 3.5, so the question is if we will have a 3.5.7 or not. > BTW if it is a blocker for you, I can create you a personal / unofficial > patched version of 3.5.6 which contains this fix and then you can use it > until you would have 3.6 or 3.5.7 later. > > You can do this for yourself as well, by cloning the 3.5 branch ( > https://github.com/apache/zookeeper/tree/branch-3.5) and executing 'mvn > clean install -DskipTests'. If you also need the C-client, then 'mvn clean > install -DskipTests -Pfull-build'. It will not be an official release, but > in this case it is actually safe to use it, as the branch 3.5 now only > contains two small bugfixes on top of the stable 3.5.6. > > Cheers, > Mate > > On Tue, Dec 3, 2019 at 5:09 PM Mike Smotritsky <mikesmotrit...@ongov.net> > wrote: > > > Hi Enrico, I'd really love to have 3.5.6 released with this fix in. > > (Thanks to Mate for the very quick fix!) > > Cause my my Solr cluster keeps complaining about the Zookeeper state. > > > > Thanks and Regards, > > Mike > > > > > > > > -----Original Message----- > > From: Enrico Olivelli [mailto:eolive...@gmail.com] > > Sent: Tuesday, December 03, 2019 10:07 AM > > To: UserZooKeeper > > Subject: Re: java.lang.NullPointerException on some commands (stats, > conf) > > > > Mike, > > just to be clear: 'we can cut new releases from 3.5 branch' means that > we > > are able to do it. > > > > But there are no plans to do it right now. > > > > If you need a release please let us know, we have just cut 3.5.6, there > > aren't so many changes cherry picked to branch-3.5 > > > > Enrico > > > > > > Il giorno lun 2 dic 2019 alle ore 18:45 Mike Smotritsky < > > mikesmotrit...@ongov.net> ha scritto: > > > > > Hi Enrico, > > > > > > Thank you very much, that would be great! > > > > > > Thanks and Regards, > > > > > > Mike > > > > > > -----Original Message----- > > > From: Enrico Olivelli [mailto:eolive...@gmail.com] > > > Sent: Monday, December 02, 2019 10:56 AM > > > To: UserZooKeeper > > > Subject: Re: java.lang.NullPointerException on some commands (stats, > > conf) > > > > > > Mike, > > > we can cut new releases from 3.5 branch. > > > It is current stable branch. > > > > > > We can cherry pick Mate's fix to branch-3.5 > > > > > > Enrico > > > > > > Il giorno lun 2 dic 2019 alle ore 16:36 Mike Smotritsky < > > > mikesmotrit...@ongov.net> ha scritto: > > > > > > > Hey Mate, on the jira issue it says that the fix will come in with > > 3.6.0 > > > > The thing is that I'm using Zookeeper with SOLR and I'm afraid that > 3.6 > > > > will be incompatible with SOLR 8.x (I don't know what new features > will > > > be > > > > included in 3.6) > > > > > > > > You are not planning one more maintenance release for 3.5? > > > > > > > > Thanks and Regards, > > > > Mike > > > > > > > > > > > > -----Original Message----- > > > > From: Mate Szalay-Beko [mailto:msza...@cloudera.com.INVALID] > > > > Sent: Thursday, November 28, 2019 11:12 AM > > > > To: user@zookeeper.apache.org > > > > Subject: Re: java.lang.NullPointerException on some commands (stats, > > > conf) > > > > > > > > FYI: https://jira.apache.org/jira/browse/ZOOKEEPER-3633 > > > > > > > > > > > > On Thu, Nov 28, 2019 at 4:53 PM Mate Szalay-Beko < > msza...@cloudera.com > > > > > > > wrote: > > > > > > > > > Hi Mike, > > > > > > > > > > I was able to reproduce the issue. I guess in your config you are > > using > > > > > client SSL. You defined 'secureClientPort', but no regular > > > 'clientPort'. > > > > > I think we missed to test the admin API for this case... I will > > create > > > a > > > > > Jira issue and try to fix it soon. > > > > > > > > > > Thanks for your time on testing ZooKeeper and reporting the > problem! > > :) > > > > > > > > > > Mate > > > > > > > > > > On Wed, Nov 27, 2019 at 8:56 PM Mike Smotritsky < > > > > mikesmotrit...@ongov.net> > > > > > wrote: > > > > > > > > > >> Hi, I've installed 3.5.5 and 3.5.6 3-server cluster. Secured and > > using > > > > >> SSLQuorum. > > > > >> All works well except that I'm getting NullPointerException when > > > > invoking > > > > >> certain commands through Web AdminServer (stats,conf) > > > > >> Others works well. > > > > >> **************************************** > > > > >> java.lang.NullPointerException > > > > >> at > > > > >> > > > > > > > > > > org.apache.zookeeper.server.ZooKeeperServer.getConf(ZooKeeperServer.java:220) > > > > >> at > > > > >> > > > > > > > > > > org.apache.zookeeper.server.admin.Commands$ConfCommand.run(Commands.java:162) > > > > >> at > > > > >> > > > org.apache.zookeeper.server.admin.Commands.runCommand(Commands.java:95) > > > > >> at > > > > >> > > > > > > > > > > org.apache.zookeeper.server.admin.JettyAdminServer$CommandServlet.doGet(JettyAdminServer.java:175) > > > > >> at > > > javax.servlet.http.HttpServlet.service(HttpServlet.java:687) > > > > >> at > > > javax.servlet.http.HttpServlet.service(HttpServlet.java:790) > > > > >> at > > > > >> > > org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:873) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:542) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:255) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1700) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:255) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1345) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:203) > > > > >> at > > > > >> > > > > > > org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:480) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1667) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:201) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1247) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:144) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:132) > > > > >> at org.eclipse.jetty.server.Server.handle(Server.java:505) > > > > >> at > > > > >> org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:370) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:267) > > > > >> at org.eclipse.jetty.io > > > > >> > > > .AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:305) > > > > >> at org.eclipse.jetty.io > > > > >> .FillInterest.fillable(FillInterest.java:103) > > > > >> at org.eclipse.jetty.io > > > > >> .ChannelEndPoint$2.run(ChannelEndPoint.java:117) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:333) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:310) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:168) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:126) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:366) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:786) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:743) > > > > >> at java.base/java.lang.Thread.run(Thread.java:834) > > > > >> java.lang.NullPointerException > > > > >> at > > > > >> > > > > > > > > > > org.apache.zookeeper.server.admin.Commands$StatCommand.run(Commands.java:461) > > > > >> at > > > > >> > > > org.apache.zookeeper.server.admin.Commands.runCommand(Commands.java:95) > > > > >> at > > > > >> > > > > > > > > > > org.apache.zookeeper.server.admin.JettyAdminServer$CommandServlet.doGet(JettyAdminServer.java:175) > > > > >> at > > > javax.servlet.http.HttpServlet.service(HttpServlet.java:687) > > > > >> at > > > javax.servlet.http.HttpServlet.service(HttpServlet.java:790) > > > > >> at > > > > >> > > org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:873) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:542) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:255) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1700) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:255) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1345) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:203) > > > > >> at > > > > >> > > > > > > org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:480) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1667) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:201) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1247) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:144) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:132) > > > > >> at org.eclipse.jetty.server.Server.handle(Server.java:505) > > > > >> at > > > > >> org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:370) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:267) > > > > >> at org.eclipse.jetty.io > > > > >> > > > .AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:305) > > > > >> at org.eclipse.jetty.io > > > > >> .FillInterest.fillable(FillInterest.java:103) > > > > >> at org.eclipse.jetty.io > > > > >> .ChannelEndPoint$2.run(ChannelEndPoint.java:117) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:786) > > > > >> at > > > > >> > > > > > > > > > > org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:743) > > > > >> at java.base/java.lang.Thread.run(Thread.java:834) > > > > >> > > > > >> > > > > >> Thanks and Regards, > > > > >> > > > > >> MIke > > > > >> > > > > > > > > > > > > > > >
