On 10/26/11 12:33, Rich Burridge wrote:
On 10/26/11 12:25 PM, Alan Coopersmith wrote:
On 10/26/11 11:30, Mike Sullivan wrote:
On 10/26/11 11:17, Alan Coopersmith wrote:
On 10/25/11 22:27, Rich Burridge wrote:
Hi,
Could I please get a code review for my fix for:
7063435 tomcat package missing dependency on java
http://monaco.us.oracle.com/detail.jsf?cr=7063435
Webrev is at:
http://jurassic.us.oracle.com/~richb/7063435-v1
Instead of depending on whichever version of Java is on the build
system, should it instead have a require-any dependency on either
runtime/java/jre-6 or runtime/java/jre-7 ?
tomcat is one thing that doesn't always like newer javas as I think
it uses interfaces that change (the commons-dbcp bits?). It didn't build the
when I tried with 7, so I'd expect it might not work with it at runtime
either.
I'd think it should depend on jre-6. You might want to consult with the
tomcat owner.
I didn't realize that - so it makes sense to just depend on jre-6 for now
and then convert to a requires-any if/when it's confirmed to be working with
jre-7 in the future (or updated to a jre-7 compatible version if necessary).
From the Bugster CR, /usr/tomcat6/bin/catalina.sh is using /usr/java/bin/java
(and potentially not finding it).
So that's what I've made the dependency on, which maps to:
depend fmri=pkg:/runtime/java/[email protected] type=require
in the generated manifest.
LGTM.
--
-Alan Coopersmith- [email protected]
Oracle Solaris Platform Engineering: X Window System
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
