On 11/10/11 12:03 PM, Danek Duvall wrote:
Rich Burridge wrote:
http://jurassic.us.oracle.com/~richb/6962990-v1/
I think this is fine. If ut_line could be not null-terminated if it took
up the full 32 bytes, then you could have a problem here in that case
(you're xmallocing 32 bytes instead of 32 bytes plus one for the extra \0).
But I don't think this can ever happen, and it's possible that ut_line is
always 31 bytes plus a \0, so it's probably not worth worrying about.
I was working off:
http://grok.cz.oracle.com:8080/source/xref/onnv-clone/usr/src/head/utmp.h#137
so I think we're safe.
Thanks for the review.
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss