On 11/21/11 10:28, Rich Burridge wrote:
Hi, Could I please get a code review for my fix for: 7056124 gcc-3 package should depend on pkg:/system/linker http://monaco.us.oracle.com/detail.jsf?cr=7056124 Webrev is at: http://jurassic.us.oracle.com/~richb/7056124-v1/ x86 Workspace (with just the gcc3 component built) is at: /net/stard.us.oracle.com/tank/ws/UL/7056124/ See the Bugster CR for more details. Thanks. _______________________________________________ userland-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/userland-discuss
I'd like to ask a wider question, as I've been told that we should avoid explicit dependencies that are not strictly necessary, in favor of letting the package system discover relationships. system/linker will always be present on any usable Solaris 11 system, because it contains the runtime linker (ld.so.1). I doubt that you could even get to single user mode without it. Since ld is also in that package, that means that the link-editor will always be present. It's fine to depend on system/linker, but everything should work without it. Given that, do we really want to have a manually maintained explicit dependency? I ask partly because of this CR, but also because I recall a few other similar CRs having been filed during the S11 endgame. That said, the fix seems fine to me. - Ali _______________________________________________ userland-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/userland-discuss
