On 11/21/11 15:14, Stacey Marshall - Solaris Software wrote:
Not you Norm, I have you lined up as CRT.
The Userland changes are very simple (thanks to all the hard work done
by the userland team):
Code review for CR 7112581 created Mon Nov 21 19:54:30 GMT 2011
S11SRU:
http://rpeweb.uk.oracle.com/~smarshal/code_review/7112581/S11SRU/webrev/index.html
16 lines changed: 1 ins; 0 del; 15 mod; 215 unchg
That looks okay to me. Do they really micro-rev the shared libraries at
every release?
(I note I've copied in "set name=pkg.human-version
value=$(COMPONENT_VERSION)" - problem?)
It looks fine to me.
S11U1:
http://rpeweb.uk.oracle.com/~smarshal/code_review/7112581/S11U1/webrev/index.html
15 lines changed: 0 ins; 0 del; 15 mod; 216 unchg
This looks okay.
Also urgent is the Solaris 10 changes - these look bad simply because
we deliver source changes in a package - its not as bad as the figures
suggest:
sfw10:
http://rpeweb.uk.oracle.com/~smarshal/code_review/7112581/sfw10/webrev/index.html
1453 lines changed: 1095 ins; 283 del; 75 mod; 5562 unchg
I am not so sure about this one. The DISTFILES.sfw file includes the
.patch* files. Was that intentional? Also, there seems to be some issue
with the collating order on some of the files, with lines that simply
moved for no apparent reason. That makes it appear to have more changes
as well.
Not so urgent are solaris 8 and 9 below (I've yet to double check
these myself)
on81:
http://rpeweb.uk.oracle.com/~smarshal/code_review/7112581/on81/webrev/index.html
15 lines changed: 0 ins; 0 del; 15 mod; 29603 unchg
Created /home/smarshal/public_html/code_review/7112581/index.html
on28:
http://rpeweb.uk.oracle.com/~smarshal/code_review/7112581/on28/webrev/index.html
15 lines changed: 0 ins; 0 del; 15 mod; 25641 unchg
Created /home/smarshal/public_html/code_review/7112581/index.html
--
blu
Always code as if the guy who ends up maintaining your code will be a
violent psychopath who knows where you live. - Martin Golding
-----------------------------------------------------------------------|
Brian Utterback - Solaris RPE, Oracle Corporation.
Ph:603-262-3916, Em:[email protected]
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
