Rich,
Thanks for the review. Comments inline....
updated webrev
http://jurassic.us.oracle.com/net/ssarva-us/export/home/srini/clone/Nov16//webrev-1/index.html
On 11/21/2011 7:40 PM, Rich Burridge wrote:
Any takers for NMAP?
I can't comment on whether the changes fix the problems they are
supposedly
fixing, but I can give you some other general comments.
I tested the fixes they work fine..
.../components/nmap/Makefile
* Line 33. Please remove the extra space so text aligns.
* Line 34. Please remove the spurious extra blank line.
Done..
.../components/nmap/nmap.p5m
* Please lose the extra space after the "dir" in all the dir actions.
It will then make it easier to see exactly what's changed.
Done...
* Line 501. Remove the version number in the legacy "desc" string.
I thought its the format of legacy "desc" string to include
version, I'm just
following other components in terms of format..
.../components/nmap/patches/001.configure.patch
.../components/nmap/patches/005.configure.patch
.../components/nmap/patches/006.configure.patch
.../components/nmap/patches/007.configure.patch
.../components/nmap/patches/008.configure.patch
.../components/nmap/patches/002.Makefile.in.patch
.../components/nmap/patches/003.Makefile.in.patch
.../components/nmap/patches/004.Makefile.in.patch
.../components/nmap/patches/009.Makefile.in.patch
* I really don't like the naming of these patches. Can something
more distinguishable be used? Perhaps a dot separated pathname.
So components/nmap/patches/007.configure.patch would become
nsock.src.configure.patch
Agree, changed the file name to path name.
Is there any reason why these need to be numbered? I thought
that was only needed if they had to be applied in a certain
order.
.../components/nmap/patches/002.Makefile.in.patch
* Line 23. /usr/ccs/bin/ar is really just /usr/bin/ar so you should
use that.
Done...
Thanks
Srini
-Srini
On 11/17/11 17:56, Srinivasa Sarva wrote:
Please review the changes for Nmap upgrade and bug fixes
http://jurassic.us.oracle.com/net/ssarva-us/export/home/srini/clone/Nov16//webrev/index.html
Except the patch 013.netutil.cc.patch all other patches are old,
I just changed the file name and so it appears to be NEW.
*
CR7113185 upgrade nmap to 5.51*
*CR6767323 nmapfe has unlocalized nmapfe.desktop*
Replaced the nmafe.desktop
*
CR6964664 nmap's ip-spoofing capability is broken*
Integrated the fix provided by [email protected]
*CR6997071 nmap chokes if allowed to pick interface*
Issue exists in nmap-5.21, got fixed in the upgraded version 5.51
Thanks
Srini
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
