On Thu, Dec 01, 2011 at 12:27:22PM -0800, Rich Burridge wrote: > On 12/ 1/11 11:29 AM, Alan Coopersmith wrote: > >On 12/01/11 11:16, Rich Burridge wrote: > >> > >>Hi, > >> > >>(I've got a feeling this one is going to generate some discussion, so > >>I'll update the bug report when we have reached agreement on the fix). > >> > >>Could I please get a code review for my fix for: > >> > >>7076617 flea tries to run /ws/onnv-tools/SUNWspro/sunstudio12.1/bin/cc > >>http://monaco.us.oracle.com/detail.jsf?cr=7076617 > >> > >>Webrev is at: > >> > >>http://jurassic.us.oracle.com/~richb/7076617-v1/ > > > >Should probably use $(CC) instead of cc in the Makefile rule, > > Yes, good point. So changed. New webrev at: > > http://jurassic.us.oracle.com/~richb/7076617-v2/
Rich, I think we should do something with this (just above your change in the muttbug.sh file): echo "(Note: This is the build environment installed on the system" echo "muttbug is run on. Information may or may not match the environment" echo "used to build mutt.)" I think something like "C compiler version information" instead of "C compiler version information for the system that built mutt" would be enough. Please remove an extra line before the "XXX-CUSAGE-XXX" mark. Please consider to add some note to the PATCHES file. I am not sure we really want this one in the PATCHES file, but we should at least think about it :-). OTOH, the change is simple and straightforward (I thought about something more complicated, but more generic). Thank you! -- Marcel Telka RPE, Systems _______________________________________________ userland-discuss mailing list userland-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/userland-discuss
