Hey Rich,
Based on the explanation in the bug report and the email archive the
changes look fine to me (FWIW I have no utility/timezone experience.)
Thanks,
Kevin.
On 12/ 5/11 04:09 AM, Rich Burridge wrote:
Anyone want to review this?
Thanks.
-------- Original Message --------
Subject: [userland-discuss] Code review request for CR #7111691
Date: Wed, 30 Nov 2011 10:26:04 -0800
From: Rich Burridge <rich.burri...@oracle.com>
To: Userland-Discuss <userland-discuss@opensolaris.org>
Hi,
Could I please get a code review for my fix for:
7111691 timezone files packaged with inappropriate preserve=false attribute
http://monaco.us.oracle.com/detail.jsf?cr=7111691
Fixing per Norm's message to the pkg-discuss mailing list at:
http://mail.opensolaris.org/pipermail/pkg-discuss/2011-November/028223.html
Webrev is at:
http://jurassic.us.oracle.com/~richb/7111691-v1/
x86 workspace (with just the timezone component built) is at:
/net/stard.us.oracle.com/tank/ws/UL/7111691/
Final published manifest is at:
/net/stard.us.oracle.com/tank/ws/UL/7111691/components/timezone/build/manifest-i386-system-data-timezone.published
Compare this with the output of:
$ pkg contents -r -m pkg:/system/data/timezone
on your system to see what's changed.
See the Bugster CR for more details.
Thanks.
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
