Rich,
Thanks for the review. I reverted the changes to reflect the original one.
Incremental webrev
http://jurassic.us.oracle.com/net/ssarva-us/export/home/srini/clone/Dec8//webrev-2/index.html
Webrev
http://jurassic.us.oracle.com/net/ssarva-us/export/home/srini/clone/Dec8//webrev/index.html
Thanks
Srini
On 12/09/11 17:39, Rich Burridge wrote:
On 12/09/2011 04:43 PM, April Chin wrote:
I only have one comment. In the Makefile, I don't think you want to
remove:
32 COMPONENT_PROJECT_URL= http://www.squid-cache.org/
Correct. And you want to revert the COMPONENT_ARCHIVE_URL line back
the way it previously was:
COMPONENT_ARCHIVE_URL=
$(COMPONENT_PROJECT_URL)Versions/v3/3.1/$(COMPONENT_ARCHIVE)
In the .p5m file:
98 -dir path=var/squid/cache group=webservd owner=webservd
mode=0755
99 -dir path=var/squid/logs group=webservd owner=webservd
mode=0755
100 -dir path=var/squid/run group=webservd owner=webservd mode=0755
101 +dir path=var/squid/cache group=webservd mode=0755
owner=webservd
102 +dir path=var/squid/logs group=webservd mode=0755
owner=webservd
103 +dir path=var/squid/run group=webservd mode=0755 owner=webservd
These lines are the same apart from you rearranging them. I suggest
putting
them back in the original order so the change doesn't show up in the
webrev.
1623 -legacy pkg=SUNWsquidr \
1624 - desc="Squid Web Proxy Cache" \
1819 +legacy pkg=SUNWsquidr desc="Squid Web Proxy Cache" \
1625 1820 name="Squid Web Proxy Cache (root)"
1626 -legacy pkg=SUNWsquidu \
1627 - desc="Squid Web Proxy Cache" \
1821 +legacy pkg=SUNWsquidu desc="Squid Web Proxy Cache" \
1628 1822 name="Squid Web Proxy Cache (usr)"
Same here. Please put it back the way it originally was, so the
unnecessary
change doesn't show up.
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
